Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svxlink usrp #547

Open
wants to merge 75 commits into
base: master
Choose a base branch
from
Open

Svxlink usrp #547

wants to merge 75 commits into from

Conversation

dl1hrc
Copy link
Contributor

@dl1hrc dl1hrc commented May 13, 2021

Hi Tobias,
would be nice if you could have a closer look to the Usrp extension. This protocol allows the communication to mmdvm and some other projects over udp.
There are some om's that currently test this extension and it looks promising but I have some questions and hope you will find the the time to answer it:

  • I think the encoder/decoder could be removed because it doesn't needed, what Audiohandler can replace it?
  • I think that the implementation of the UsrpMessages in UsrpMsg.h can be done better, I'm not satisfied with that. Can you give me some hints please?
  • There is an error message when the SvxLink is ended by 'q'. I can not find the reason for it. It seems that one method of the EventHandler is started when the destructor starts to cleanup the resources but I'm not sure:

Program received signal SIGSEGV, Segmentation fault.
0x00005555555f84e5 in EventHandler::processEvent(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) ()
(gdb) bt
#0 0x00005555555f84e5 in EventHandler::processEvent(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) ()
#1 0x00005555555dd6aa in Logic::processEvent(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, Module const*) [clone .constprop.0] ()
#2 0x00005555555dd982 in Logic::sendRgrSound() ()
#3 0x00005555555e0b7d in Logic::checkIdle() ()
#4 0x00005555555ee792 in non-virtual thunk to Async::AudioStreamStateDetector::allSamplesFlushed() ()
#5 0x00007ffff7f6fcc0 in Async::AudioMixer::allSamplesFlushed() () from /lib/x86_64-linux-gnu/libasyncaudio.so.1.6
#6 0x00007ffff7f6faf7 in Async::AudioMixer::outputHandler(Async::Timer*) [clone .part.0] () from /lib/x86_64-linux-gnu/libasyncaudio.so.1.6
#7 0x00007ffff7f5e1ed in Async::AudioSink::unregisterSource() () from /lib/x86_64-linux-gnu/libasyncaudio.so.1.6
#8 0x00007ffff7f5e3bb in Async::AudioSink::~AudioSink() () from /lib/x86_64-linux-gnu/libasyncaudio.so.1.6
#9 0x000055555564df94 in LocalTx::~LocalTx() ()
#10 0x000055555564e0fd in LocalTx::~LocalTx() ()
#11 0x00005555555e2336 in Logic::cleanup() ()
#12 0x00005555555e24e0 in Logic::~Logic() ()
#13 0x00005555555f2986 in RepeaterLogic::~RepeaterLogic() ()
#14 0x00005555555d328f in main ()
(gdb)

mni 73s de Adi / DL1HRC

…ion. Remaining Bug: unpack USRP_TYPE_TEXT message
…ta,-)messages.. Add some checks for pack/unpack in AsyncMsg.h
…om Waldek/SP2ONG added, removed unused methods
Copy link
Owner

@sm0svx sm0svx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first review for this PR. I've just looked at the easy changes right now. Another more indepth review is needed but it's a start.

I have moved some changes, like AsyncMsg.h, to master and merged them back into this branch.

CONFIG.adoc Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to the UsrpLogic directory

INSTALL.adoc Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove/move changes to the UsrpLogic subdirectory. The missing dependencies have been committed to master.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to UsrpLogic specific manual page.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move changes to UsrpLogic subdirectory.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to UsrpLogic subdirectory.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move changes to UsrpLogic subdirectory.

src/versions Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove USRPSUPPORT version from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants