Skip to content
This repository has been archived by the owner on Jun 4, 2019. It is now read-only.

Develop issue136 lists vs sets #140

Merged
merged 14 commits into from Jun 14, 2018
Merged

Conversation

reteprelief
Copy link
Contributor

Fixes #136
There was an issue with comparing lists and sets when empty lists or sets are involved.

@reteprelief reteprelief requested a review from kfhoech June 12, 2018 12:39
Copy link
Contributor

@kfhoech kfhoech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. In future it would be nice to statically determine the type of the aggregates rather than depending upon having an element. I'll open an issue on that and hopefully get to it when I have time.

@kfhoech kfhoech merged commit 9606b4e into master Jun 14, 2018
@kfhoech kfhoech deleted the develop_issue136_lists_vs_sets branch June 14, 2018 11:17
@kfhoech kfhoech restored the develop_issue136_lists_vs_sets branch June 15, 2018 11:19
@kfhoech kfhoech deleted the develop_issue136_lists_vs_sets branch June 15, 2018 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants