This repository has been archived by the owner on Jun 4, 2019. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix comparison of NamedElement instances
SetType(BaseType.ANY). Before it was set to BaseType.Fail. Adjusted toString of ListType and SetType to generate '[]' and '{}' without the 'any'. Fixed comparison in checkPropertyCall to compare types as well as parametric types.
kfhoech
approved these changes
Jun 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. In future it would be nice to statically determine the type of the aggregates rather than depending upon having an element. I'll open an issue on that and hopefully get to it when I have time.
This was referenced Jun 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
There was an issue with comparing lists and sets when empty lists or sets are involved.