Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _library.ts to support SDL2 installed by homebrew #23

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Update _library.ts to support SDL2 installed by homebrew #23

merged 2 commits into from
Feb 13, 2024

Conversation

Jonham
Copy link
Contributor

@Jonham Jonham commented Feb 13, 2024

to enable lib linking on Mac (x64), install sdl2 using Homebrew.

brew install sdl2 sdl2_image sdl2_ttf

Homebrew will install into /usr/local/lib by default.

@smack0007
Copy link
Owner

LGTM but does it make sense to search "/usr/local/lib" first and then "/System/Volumes/Data/opt/homebrew/lib"? Switch the order I mean.

Jonham
Jonham commented Feb 13, 2024
View reviewed changes
src/deno/_library.ts Outdated Show resolved Hide resolved
@Jonham
Copy link
Contributor Author

Jonham commented Feb 13, 2024 •
edited

LGTM but does it make sense to search "/usr/local/lib" first and then "/System/Volumes/Data/opt/homebrew/lib"? Switch the order I mean.

switched.

@smack0007 smack0007 merged commit 0ed7daa into smack0007:main Feb 13, 2024
@Jonham Jonham mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jonham @smack0007