Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cchardet no longer updated #166

Closed
vevv opened this issue Oct 27, 2022 · 7 comments
Closed

cchardet no longer updated #166

vevv opened this issue Oct 27, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@vevv
Copy link

vevv commented Oct 27, 2022

cchardet, a dependency of ffsubsync is no longer supported, and will not build correctly on Python 3.11 on Windows 10.
See: PyYoshi/cChardet#77

charset_normalizer seems like a decent drop-in replacement others suggest

@vevv vevv added the bug Something isn't working label Oct 27, 2022
vevv added a commit to vevv/ffsubsync that referenced this issue Oct 27, 2022
@DoTheEvo
Copy link

So what can I do to get pip install ffsubsync working?

@vevv
Copy link
Author

vevv commented Dec 12, 2022

You can use my fork. pip install ffsubsync@git+https://github.com/vevv/ffsubsync@e0ef745

@smacke
Copy link
Owner

smacke commented Dec 31, 2022

Thanks for flagging. I took a look at charset_normalizer and it seems like a good stopgap for now for later versions of Python. Unfortunately it seems to have some gaps when compared with cchardet, e.g. for detecting more obscure encodings such as BIG5. Anyway the next release will prefer charset_normalizer over cchardet on Windows + Python 3.11.

@reliant8307
Copy link

Thanks for flagging. I took a look at charset_normalizer and it seems like a good stopgap for now for later versions of Python. Unfortunately it seems to have some gaps when compared with cchardet, e.g. for detecting more obscure encodings such as BIG5. Anyway the next release will prefer charset_normalizer over cchardet on Windows + Python 3.11.

I'm getting the same issue using Linux when trying to build 0.4.21 version (cchardet won't build because it can't find longintrepr.h when using Python 3.11). Could you apply this change to Linux too?

I commented out the requirements.txt line from git and it's working fine here:

#cchardet;platform_system!='Windows'

Thanks!

@smacke
Copy link
Owner

smacke commented Dec 31, 2022

@reliant8307 thanks for raising -- just pushed a new version that fixes this. For some reason I thought it was only Windows that had issues with cchardet on Python 3.11, but looks like it's all OSes.

@StayBlue
Copy link

Instead of using cchardet, it's possible to just use faust-cchardet, a maintained version of cchardet.

@smacke
Copy link
Owner

smacke commented Mar 26, 2023

Thanks for the pointer! I've deployed an update to use faust-cchardet in the latest version of ffsubsync.

@smacke smacke closed this as completed Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants