Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload template points at minified JS file that was removed at django 3.2 #75

Closed
andylolz opened this issue Mar 2, 2022 · 1 comment · Fixed by #76
Closed

Upload template points at minified JS file that was removed at django 3.2 #75

andylolz opened this issue Mar 2, 2022 · 1 comment · Fixed by #76

Comments

@andylolz
Copy link

andylolz commented Mar 2, 2022

admin/js/collapse.min.js is referenced here:

<script type="text/javascript" src="{% static "admin/js/collapse.min.js" %}"></script>

This minified file was removed at django 3.2:
https://docs.djangoproject.com/en/3.2/releases/3.2/#id1

Minified JavaScript files are no longer included with the admin. If you require these files to be minified, consider using a third party app or external build tool. The minified vendored JavaScript files packaged with the admin (e.g. jquery.min.js) are still included.

It would be forwards and backwards compatible to instead reference the unminified version here.

@smacker
Copy link
Owner

smacker commented Mar 2, 2022

I released the new version with your fix: https://pypi.org/project/django-filebrowser-no-grappelli/#history

file-browser 4 dropped old django versions so I think we can just require v3.2 as the new minimal compatible django.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants