Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve query handling and fix predicates filtering #102

Merged
merged 3 commits into from
May 1, 2023

Conversation

wesen
Copy link
Contributor

@wesen wesen commented Apr 23, 2023

This improves handlingn of query errors by:

  • extracting the identifier (for NodeType, Field and Capture errors)
  • extracting the relevant line (for Structure, Syntax and Language errors)

It also fixes predicate handling (see #101) in order to not filter out captures
that don't have an associated predicate.

@smacker
Copy link
Owner

smacker commented May 1, 2023

Great work! Thank you.

@smacker smacker merged commit a7d9277 into smacker:master May 1, 2023
4 checks passed
@wesen
Copy link
Contributor Author

wesen commented May 1, 2023

Great work! Thank you.

likewise!

@wesen wesen deleted the misc/improve-query-handling branch May 1, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants