Refactored clone_dependant #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smagafurov
reviewed
Feb 12, 2020
tests/test_utils.py
Outdated
|
|
||
| # all fields from original represented in cloned | ||
| assert list(original_dependant.__dict__.keys()) == list(cloned_dependant.__dict__.keys()) | ||
| assert list(original_dependant.__dict__.values()) == list(cloned_dependant.__dict__.values()) |
There was a problem hiding this comment.
Test fails here for me:
> assert list(original_dependant.__dict__.values()) == list(cloned_dependant.__dict__.values())
E AssertionError: assert [[],\n [],\n [],\n [],\n [],\n [<fastapi.dependencies.models.Dependant object at 0x1048eaf60>],\n [],\n 'ss',\n 'ss',\n 'aaa',\n 'ss',\n ['sss'],\n 'sss',\n 'some name',\n <function test_clone_dependant.<locals>.<lambda> at 0x10497e6a8>,\n False,\n 'some path',\n (<function test_clone_dependant.<locals>.<lambda> at 0x10497e6a8>, ('sss',))] == [[],\n [],\n [],\n [],\n [],\n [<fastapi.dependencies.models.Dependant object at 0x10498ef98>],\n [],\n 'ss',\n 'ss',\n 'aaa',\n 'ss',\n ['sss'],\n 'sss',\n 'some name',\n <function test_clone_dependant.<locals>.<lambda> at 0x10497e6a8>,\n False,\n 'some path',\n (<function test_clone_dependant.<locals>.<lambda> at 0x10497e6a8>, ('sss',))]
test_utils.py:26: AssertionError
|
up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old version: In case if Dependant model will change you have to add new lines to function
New version: Everything will be copied automatically
Fixing #4