Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gatsby-plugin-alias-imports #3

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Conversation

ajayns
Copy link
Contributor

@ajayns ajayns commented Feb 11, 2019

The current config with custom code in gatsby-node.js for alias imports causes issues when used with styled-components to import constants: gatsbyjs/gatsby#11352

Using this plugin seems to resolve that issue and further give an overall clean/maintainable project structure than the current setup for alias imports.

@smakosh smakosh self-requested a review February 20, 2019 14:48
@smakosh smakosh added the enhancement New feature or request label Feb 20, 2019
Copy link
Owner

@smakosh smakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍thanks for the contribution! I should add a contributions section to the README file as well, no worries! I won't forget to add it!

@smakosh smakosh merged commit e138489 into smakosh:master Feb 20, 2019
@ajayns ajayns deleted the alias-imports branch February 26, 2019 04:34
@ajayns
Copy link
Contributor Author

ajayns commented Feb 26, 2019

Great! Always happy to help :)

@smakosh
Copy link
Owner

smakosh commented Feb 26, 2019

3cf723f 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants