-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Support for LSP 3.18 inline completions #3
Comments
/bounty 500 |
💎 $500 bounty created by smallcloudai |
/attempt #3 |
@mrkirthi-24: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started. |
/attempt #3 |
@VitthalGupta: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started. |
@AayushMohan: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started. |
Hey @AayushMohan @VitthalGupta , based on previous bounties we'd like to avoid several people duplicating the work. Did one of you made any initial progress? Can you shoot a very short video? If the progress is there, I think it better to "assign" this issue to a single person. |
/attempt |
@ferasawadi: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started. |
/attempt #3 |
@digital-phoenix: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started. |
Anyone has progress on this? |
💡 @digital-phoenix submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
Is this issue still open? |
This got stuck because we found that LSP calls are not enough anyway, for example we need to know when user accepts the suggestion. And some IDEs send nothing at all for certain programming languages (!), that's unreliable from our POV. |
# This is the 1st commit message: WIP # This is the commit message #2: fix # This is the commit message #3: WIP # This is the commit message #4: fixed deps! # This is the commit message #5: changes requested by @olegklimov # This is the commit message #6: simplified get_embedding_openai_style and get_embedding_hf_style: removed attempts # This is the commit message #7: removed hardcoded hf_url; fixed some naming # This is the commit message #8: restoring order in args & naming # This is the commit message #9: vecdb is now dynamically reloading # This is the commit message #10: implemented changes request from @olegklimov # This is the commit message #11: minor # This is the commit message #12: minor # This is the commit message #13: added endpoint_embeddings_style # This is the commit message #14: init changelist: * added additional tries to embedding requests' * added init folders as a vecdb's method. Calling from vecdb_background_reload and LSP::initialize changelist: * creating new database if emb_size if different * if emb_size is equal, deleting embeddings creating for another model changelist: * removed remove_where_old_model * creating dedicated db_dir using key (model_name, embedding_size) vecdb is reloading only if caps changes. It checks for it every 30s
# This is the 1st commit message: WIP # This is the commit message #2: fix # This is the commit message #3: WIP # This is the commit message #4: fixed deps! # This is the commit message #5: changes requested by @olegklimov # This is the commit message #6: simplified get_embedding_openai_style and get_embedding_hf_style: removed attempts # This is the commit message #7: removed hardcoded hf_url; fixed some naming # This is the commit message #8: restoring order in args & naming # This is the commit message #9: vecdb is now dynamically reloading # This is the commit message #10: implemented changes request from @olegklimov # This is the commit message #11: minor # This is the commit message #12: minor # This is the commit message #13: added endpoint_embeddings_style # This is the commit message #14: init changelist: * added additional tries to embedding requests' * added init folders as a vecdb's method. Calling from vecdb_background_reload and LSP::initialize changelist: * creating new database if emb_size if different * if emb_size is equal, deleting embeddings creating for another model changelist: * removed remove_where_old_model * creating dedicated db_dir using key (model_name, embedding_size) vecdb is reloading only if caps changes. It checks for it every 30s
can i fix the issue /attempt #3 Options |
@PlanetKumbhaj: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started. |
Can I work on it |
@olegklimov Can I work on this ? |
@olegklimov if this is no longer a valid issue can you close it? |
This will be the right choice, otherwise it's really misleading |
Right, this thing has self-dissolved... |
We have an LSP function that does code completion, but it's a custom function.
Here's the specification from Microsoft:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#textDocument_inlineCompletion
So we want to keep the custom function, to keep existing plugins working, but also add all the necessary bits and pieces for 3.18 inline completion support.
The text was updated successfully, but these errors were encountered: