Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Support for LSP 3.18 inline completions #3

Closed
olegklimov opened this issue Oct 18, 2023 · 24 comments
Closed

[rust] Support for LSP 3.18 inline completions #3

olegklimov opened this issue Oct 18, 2023 · 24 comments

Comments

@olegklimov
Copy link
Contributor

We have an LSP function that does code completion, but it's a custom function.

Here's the specification from Microsoft:

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#textDocument_inlineCompletion

So we want to keep the custom function, to keep existing plugins working, but also add all the necessary bits and pieces for 3.18 inline completion support.

@olegklimov
Copy link
Contributor Author

/bounty 500

@algora-pbc
Copy link

algora-pbc bot commented Oct 18, 2023

💎 $500 bounty created by smallcloudai
🙋 If you'd like to work on this issue, comment below to get assigned
👉 To claim this bounty, submit a pull request that includes the text /claim #3 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to smallcloudai/refact-lsp!

👉 Add a bountyShare on socials

@mrkirthi-24
Copy link

/attempt #3

@algora-pbc
Copy link

algora-pbc bot commented Oct 18, 2023

@mrkirthi-24: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

@VitthalGupta
Copy link

/attempt #3

@algora-pbc
Copy link

algora-pbc bot commented Oct 18, 2023

@VitthalGupta: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

@olegklimov
Copy link
Contributor Author

Added LSP custom function example

@algora-pbc
Copy link

algora-pbc bot commented Oct 23, 2023

@AayushMohan: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

@olegklimov
Copy link
Contributor Author

Hey @AayushMohan @VitthalGupta , based on previous bounties we'd like to avoid several people duplicating the work. Did one of you made any initial progress? Can you shoot a very short video? If the progress is there, I think it better to "assign" this issue to a single person.

@ferasawadi
Copy link

/attempt

@algora-pbc
Copy link

algora-pbc bot commented Oct 26, 2023

@ferasawadi: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

@digital-phoenix
Copy link

/attempt #3

@algora-pbc
Copy link

algora-pbc bot commented Oct 28, 2023

@digital-phoenix: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

@olegklimov
Copy link
Contributor Author

Anyone has progress on this?

Copy link

algora-pbc bot commented Nov 7, 2023

💡 @digital-phoenix submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@mahimairaja
Copy link

mahimairaja commented Dec 30, 2023

Is this issue still open?

@olegklimov
Copy link
Contributor Author

This got stuck because we found that LSP calls are not enough anyway, for example we need to know when user accepts the suggestion. And some IDEs send nothing at all for certain programming languages (!), that's unreliable from our POV.

valaises added a commit that referenced this issue Jan 12, 2024
# This is the 1st commit message:

WIP

# This is the commit message #2:

fix

# This is the commit message #3:

WIP

# This is the commit message #4:

fixed deps!

# This is the commit message #5:

changes requested by @olegklimov

# This is the commit message #6:

simplified get_embedding_openai_style and get_embedding_hf_style:
removed attempts

# This is the commit message #7:

removed hardcoded hf_url; fixed some naming

# This is the commit message #8:

restoring order in args & naming

# This is the commit message #9:

vecdb is now dynamically reloading

# This is the commit message #10:

implemented changes request from @olegklimov

# This is the commit message #11:

minor

# This is the commit message #12:

minor

# This is the commit message #13:

added endpoint_embeddings_style

# This is the commit message #14:

init

changelist:
* added additional tries to embedding requests'
* added init folders as a vecdb's method. Calling from vecdb_background_reload and LSP::initialize

changelist:
* creating new database if emb_size if different
* if emb_size is equal, deleting embeddings creating for another model

changelist:
* removed remove_where_old_model
* creating dedicated db_dir using key (model_name, embedding_size)

vecdb is reloading only if caps changes. It checks for it every 30s
valaises added a commit that referenced this issue Jan 12, 2024
# This is the 1st commit message:

WIP

# This is the commit message #2:

fix

# This is the commit message #3:

WIP

# This is the commit message #4:

fixed deps!

# This is the commit message #5:

changes requested by @olegklimov

# This is the commit message #6:

simplified get_embedding_openai_style and get_embedding_hf_style:
removed attempts

# This is the commit message #7:

removed hardcoded hf_url; fixed some naming

# This is the commit message #8:

restoring order in args & naming

# This is the commit message #9:

vecdb is now dynamically reloading

# This is the commit message #10:

implemented changes request from @olegklimov

# This is the commit message #11:

minor

# This is the commit message #12:

minor

# This is the commit message #13:

added endpoint_embeddings_style

# This is the commit message #14:

init

changelist:
* added additional tries to embedding requests'
* added init folders as a vecdb's method. Calling from vecdb_background_reload and LSP::initialize

changelist:
* creating new database if emb_size if different
* if emb_size is equal, deleting embeddings creating for another model

changelist:
* removed remove_where_old_model
* creating dedicated db_dir using key (model_name, embedding_size)

vecdb is reloading only if caps changes. It checks for it every 30s
@thekumbhaj
Copy link

thekumbhaj commented Jan 16, 2024

can i fix the issue /attempt #3

Copy link

algora-pbc bot commented Jan 16, 2024

@PlanetKumbhaj: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

@MayorChristopher
Copy link

Can I work on it

@Sambit003
Copy link

@olegklimov Can I work on this ?

@digital-phoenix
Copy link

@olegklimov if this is no longer a valid issue can you close it?

@Sambit003
Copy link

@olegklimov if this is no longer a valid issue can you close it?

This will be the right choice, otherwise it's really misleading

@olegklimov
Copy link
Contributor Author

Right, this thing has self-dissolved...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants