Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't restart refact-lsp in some cases #24

Open
hazratisulton opened this issue Jan 9, 2024 · 11 comments
Open

Can't restart refact-lsp in some cases #24

hazratisulton opened this issue Jan 9, 2024 · 11 comments

Comments

@hazratisulton
Copy link

Steps to reproduce:
Create new file, for example, .cpp.
Use completion.
Restart IDE.
Create new file
Try to use completion.

Expected result:
Refact plugin works.

Actual result:
Снимок экрана 2024-01-09 100917
Снимок экрана 2024-01-09 101623
Completion doesn't work because process refact-lsp did not complete from the previous launch.
Sometimes another reboot may be necessary to reproduce the problem.

Software versions:
Microsoft Visual Studio Community 2022 (64-bit) - Current Version 17.8.4
Refact plugin v 0.0.1
Windows 11 Pro 22H2 22621.2861

Logs:
ActivityLog.zip

@hazratisulton
Copy link
Author

@digital-phoenix

@digital-phoenix
Copy link
Contributor

@hazratisulton are you running the plugin from source or from the package installer?

@hazratisulton
Copy link
Author

@digital-phoenix Installed from marketplace
изображение

@digital-phoenix
Copy link
Contributor

@hazratisulton the marketplace version is out of date. You'll have to wait for it to be updated.

@hazratisulton
Copy link
Author

hazratisulton commented Jan 11, 2024

Checked yesterday version https://github.com/smallcloudai/refact-vs-classic/actions/runs/7469728225/artifacts/1158463034 - still have problem.

Steps to reproduce:
Create new file, for example, .cpp.
Use completion.
Create new project, for example, Empty Project.
Add -> New item - FileName.cpp
Try to use completion.

Result:
Completion not working
image.

ActivityLog.zip
rustbinary.zip

@hazratisulton hazratisulton changed the title VS Classic doesn't kill refact-lsp after closing IDE Can't restart refact-lsp in some cases Jan 11, 2024
@digital-phoenix
Copy link
Contributor

@hazratisulton can you include the log files?

@hazratisulton
Copy link
Author

@hazratisulton can you include the log files?

updated previous message

@hazratisulton
Copy link
Author

hazratisulton commented Jan 23, 2024

@olegklimov
Copy link
Contributor

Disposed object -- that looks like a bug that shouldn't happen in any case.

@digital-phoenix
Copy link
Contributor

@hazratisulton can you confirm if this only happens as a result of creatng a new project after using completions? Does this happen if you don't create a project?

@olegklimov
Copy link
Contributor

If there is no http port that RefactLanguageClient.cs opens, then there's no obvious reason for lsp to fail to start.

process refact-lsp did not complete from the previous launch

This could be the case if it was the port, the same hardcoded port, but there isn't any 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants