Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
调用
ringbuffer.Bytes()
的时候,如果 buffer 是满的,也就是r.w == r.r
,copyr.buf
的顺序不应该是 0 -> r.size,因为 r.r 和 r.w 此时未必等于 0,所以 copy 的范围应该是先 r.r -> r.size,然后 0 -> r.w,否则的话返回的数据的顺序是乱的。