Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback validation shouldn't allow to define fallback method on a subclass #122

Closed
manovotn opened this issue Oct 11, 2019 · 2 comments · Fixed by #123
Closed

Fallback validation shouldn't allow to define fallback method on a subclass #122

manovotn opened this issue Oct 11, 2019 · 2 comments · Fixed by #123
Assignees
Milestone

Comments

@manovotn
Copy link
Contributor

As was pointed out to me here, spec forbids to declare fallback methods on subclasses:

When fallbackMethod is used a FaultToleranceDefinitionException will be thrown if any of the following constraints are not met:

    The named fallback method must be on the same class, a superclass or an implemented interface of the class which declares the annotated method
    [...]
    The named fallback method must be accessible from the class which declares the annotated method

Currently, smallrye doesn't seem to check that and we just happen to pass the TCK because we actually blow up (with exactly the same exception) on validating the superclass alone.

@manovotn manovotn self-assigned this Oct 11, 2019
@kenfinnigan
Copy link
Contributor

Ouch, definitely need to fix that

@manovotn
Copy link
Contributor Author

Yep, I'll send a PR for that once I am done with one another thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants