Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite metrics system #185

Closed
Ladicek opened this issue Feb 6, 2020 · 2 comments · Fixed by #264
Closed

rewrite metrics system #185

Ladicek opened this issue Feb 6, 2020 · 2 comments · Fixed by #264
Assignees
@Ladicek
Milestone
5.0.0

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Feb 6, 2020

The metrics system we have mostly comes from SmallRye Fault Tolerance 2.x. We should be able to make it simpler; for example, SmallRye Metrics is now thread-safe, so we don't have to synchronize ourselves.
@Ladicek Ladicek self-assigned this May 21, 2020
@Ladicek
Copy link
Contributor Author

Ladicek commented May 21, 2020 •
edited

I have done this when implementing the new metrics that will come in MP FT 3.0: https://github.com/Ladicek/smallrye-fault-tolerance/commits/new-metrics

All metrics are now being collected in a single dedicated FaultToleranceStrategy, and all other strategies just emit events on the InvocationContext. This improves source locality at a small runtime cost.

@Ladicek Ladicek mentioned this issue Aug 4, 2020
Merged
@Ladicek
Copy link
Contributor Author

Ladicek commented Aug 6, 2020

Done in #264.

@Ladicek Ladicek closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ladicek Ladicek

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

implement MicroProfile Fault Tolerance 3.0 Ladicek/smallrye-fault-tolerance
1 participant
@Ladicek