Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document difference between MultiFlatten concatenate and merge #82

Closed
zeljkot opened this issue Mar 17, 2020 · 1 comment · Fixed by #106
Closed

Document difference between MultiFlatten concatenate and merge #82

zeljkot opened this issue Mar 17, 2020 · 1 comment · Fixed by #106
Assignees
@cescoffier

Comments

@zeljkot
Copy link

zeljkot commented Mar 17, 2020 •
edited

Both methods have same signature, same return type, and almost the same description. They call the same MultiFlatMapOp constructor with a different concurrency parameter. It is hard to figure out what is the difference and what to use.

Version: 0.4.0
@cescoffier cescoffier self-assigned this Mar 17, 2020
@cescoffier cescoffier mentioned this issue Mar 18, 2020
Closed
@zeljkot
Copy link
Author

zeljkot commented Mar 18, 2020

BTW Good explanation of merge vs concatenate. So concatenate is executed with 1 internal stream while the merge is executed with 256? As Java already has parallel streamy, for me it would be simple if you name it merge and mergeParallel (or concatenateXxxx). Also, it would be easier to find my options with autocomplete.

@cescoffier cescoffier mentioned this issue Apr 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cescoffier cescoffier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document the difference between concatenate() and merge() smallrye/smallrye-mutiny
2 participants
@cescoffier @zeljkot