Skip to content

Commit

Permalink
Add sync.WaitGroup for proper error handling in Run()
Browse files Browse the repository at this point in the history
  • Loading branch information
hslatman authored and dopey committed May 26, 2021
1 parent 1cd0cb9 commit 03c4723
Showing 1 changed file with 24 additions and 1 deletion.
25 changes: 24 additions & 1 deletion ca/ca.go
Expand Up @@ -8,6 +8,7 @@ import (
"net/http"
"net/url"
"reflect"
"sync"

"github.com/go-chi/chi"
"github.com/pkg/errors"
Expand Down Expand Up @@ -251,7 +252,29 @@ func (ca *CA) Init(config *config.Config) (*CA, error) {

// Run starts the CA calling to the server ListenAndServe method.
func (ca *CA) Run() error {
return ca.srv.ListenAndServe()
var wg sync.WaitGroup
errors := make(chan error, 1)

if ca.insecureSrv != nil {
wg.Add(1)
go func() {
defer wg.Done()
errors <- ca.insecureSrv.ListenAndServe()
}()
}

wg.Add(1)
go func() {
defer wg.Done()
errors <- ca.srv.ListenAndServe()
}()

// wait till error occurs; ensures the servers keep listening
err := <-errors

wg.Wait()

return err
}

// Stop stops the CA calling to the server Shutdown method.
Expand Down

0 comments on commit 03c4723

Please sign in to comment.