Skip to content

Commit

Permalink
Move golangci-lint to github action | update bootstrap
Browse files Browse the repository at this point in the history
- Update bootstrap to use official golangci-lint install
  • Loading branch information
dopey committed Apr 13, 2021
1 parent 72217c9 commit 42a470d
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 3 deletions.
26 changes: 25 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,34 @@ jobs:
name: Install Deps
id: install-deps
run: sudo apt-get -y install libpcsclite-dev
-
name: golangci-lint
uses: golangci/golangci-lint-action@v2
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: 'latest'

# Optional: working directory, useful for monorepos
# working-directory: somedir

# Optional: golangci-lint command line arguments.
# args: --issues-exit-code=0

# Optional: show only new issues if it's a pull request. The default value is `false`.
# only-new-issues: true

# Optional: if set to true then the action will use pre-installed Go.
# skip-go-installation: true

# Optional: if set to true then the action don't cache or restore ~/go/pkg.
# skip-pkg-cache: true

# Optional: if set to true then the action don't cache or restore ~/.cache/go-build.
# skip-build-cache: true
-
name: Lint, Test, Build
id: lint_test_build
run: V=1 make -j1 bootstrap ci
run: V=1 make ci

create_release:
name: Create Release
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ OUTPUT_ROOT=output/

all: lint test build

ci: lintcgo testcgo build
ci: testcgo build

.PHONY: all ci

Expand All @@ -28,7 +28,7 @@ ci: lintcgo testcgo build

bootstra%:
# Using a released version of golangci-lint to take into account custom replacements in their go.mod
$Q go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.24.0
$Q curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.39.0

.PHONY: bootstra%

Expand Down

0 comments on commit 42a470d

Please sign in to comment.