Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helpful message on CA startup when config can't be opened #1252

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Helpful message on CA startup when config can't be opened #1252

merged 4 commits into from
Feb 1, 2023

Conversation

tashian
Copy link
Contributor

@tashian tashian commented Jan 31, 2023

Closes #1248

@tashian tashian requested a review from dopey January 31, 2023 20:11
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jan 31, 2023
maraino
maraino requested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not the right place to put this. If you look at

certificates/commands/app.go

Lines 149 to 152 in 40538d8

cfg, err := config.LoadConfiguration(configFile)
if err != nil && token == "" {
fatal(err)
}

This is expected to fail if the server is using the automatic RA configuration, without a ca.json.

@tashian tashian requested a review from maraino January 31, 2023 20:36
maraino
maraino reviewed Jan 31, 2023
View reviewed changes
commands/app.go Outdated Show resolved Hide resolved
@tashian @maraino
Update commands/app.go
b76028f 
Co-authored-by: Mariano Cano <mariano@smallstep.com>
@tashian tashian requested a review from maraino January 31, 2023 22:40
maraino
maraino approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tashian tashian merged commit 067f9c9 into master Feb 1, 2023
@tashian tashian deleted the carl/startup-noconfig-msg branch February 1, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

@dopey dopey dopey approved these changes

Assignees
No one assigned
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When running step-ca when no config file is present, the output could be more helpful.
3 participants
@tashian @maraino @dopey