Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return more detailed errors to ACME clients using device-attest-01 #1495

Merged
merged 13 commits into from
Aug 4, 2023

Conversation

hslatman
Copy link
Member

No description provided.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jul 28, 2023
@hslatman hslatman requested a review from maraino July 31, 2023 09:59
@hslatman hslatman added this to the v0.24.3 milestone Aug 1, 2023
acme/challenge.go Outdated Show resolved Hide resolved
acme/challenge.go Outdated Show resolved Hide resolved
acme/errors.go Show resolved Hide resolved
@hslatman hslatman requested a review from maraino August 3, 2023 13:09
maraino
maraino previously approved these changes Aug 3, 2023
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this, but I think we should use NewDetailedError instead.

@hslatman
Copy link
Member Author

hslatman commented Aug 4, 2023

Had to fix merge conflict, so also updated to NewDetailedError in c952e9f.

@hslatman hslatman requested a review from maraino August 4, 2023 14:36
@hslatman hslatman enabled auto-merge August 4, 2023 14:36
@hslatman hslatman merged commit 6de964f into master Aug 4, 2023
13 checks passed
@hslatman hslatman deleted the herman/acme-attestation-errors branch August 4, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants