Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provisionerOptionsToLinkedCA missing template and templateData #1520

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

dopey
Copy link
Contributor

@dopey dopey commented Aug 29, 2023

@dopey dopey requested a review from maraino August 29, 2023 23:10
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Aug 29, 2023
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting

@dopey dopey merged commit e22166c into master Aug 30, 2023
15 checks passed
@dopey dopey deleted the max/provisioner-template branch August 30, 2023 00:26
@@ -754,13 +754,17 @@ func provisionerOptionsToLinkedca(p *provisioner.Options) (*linkedca.Template, *
}

if p.X509.Template != "" {
x509Template.Template = []byte(p.SSH.Template)
x509Template.Template = []byte(p.X509.Template)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Updating provisioner configuration makes template configuration disappear
3 participants