Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate request ID when webhook requests are made #1542

Merged
merged 9 commits into from
Feb 27, 2024
Merged

Propagate request ID when webhook requests are made #1542

merged 9 commits into from
Feb 27, 2024

Commits on Sep 19, 2023

  1. Propagate (original) request ID to webhook requests 

    Technically the webhook request is a new request, so maybe the
`X-Request-ID` should not be set to the value of the original
request? But then the original request ID should be propageted
in the webhook request body, or using a different header.

The way the request ID is used in this functionality is actually
more like a tracing ID, so that may be an option too.
    @hslatman
    hslatman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f3229d3 View commit details
    Browse the repository at this point in the history

  2. Remove the webhook Do method

    @hslatman
    hslatman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b2301ea View commit details
    Browse the repository at this point in the history

  3. Add SignWithContext method to authority and mocks

    @hslatman
    hslatman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4e06bdb View commit details
    Browse the repository at this point in the history

  4. Use SignWithContext in the critical paths

    @hslatman
    hslatman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9e3807e View commit details
    Browse the repository at this point in the history

  5. Fix broken tests relying on Sign in mocks

    @hslatman
    hslatman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4ef093d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Merge branch 'master' into herman/webhook-request-id

    @hslatman
    hslatman committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2a8b80a View commit details
    Browse the repository at this point in the history

  2. Add tests for webhook request IDs

    @hslatman
    hslatman committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9689508 View commit details
    Browse the repository at this point in the history

  3. Remove smallstep/assert and pkg/errors from webhook tests

    @hslatman
    hslatman committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c16a0b7 View commit details
    Browse the repository at this point in the history

  4. Remove usages of Sign without context

    @hslatman
    hslatman committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    041b486 View commit details
    Browse the repository at this point in the history