Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCEP issuance notification webhook #1544

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Add SCEP issuance notification webhook #1544

merged 6 commits into from
Sep 22, 2023

Conversation

hslatman
Copy link
Member

No description provided.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Sep 21, 2023
maraino
maraino reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. There's one almost "empty" file committed. And I wonder if the use of Win32 error codes is too specific but the notifying type looks quite generic.

authority/admin/api/webhook.go Outdated Show resolved Hide resolved
authority/provisioner/scep.go Outdated Show resolved Hide resolved
scep/api/api.go Outdated Show resolved Hide resolved
scep/context.go Outdated Show resolved Hide resolved
maraino
maraino approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

TIL, wrapping twice implements interface{ Unwrap() []error }, it does not implements interface{ Unwrap() error }.

See https://go.dev/play/p/gCm8j14Jf79

@hslatman hslatman merged commit 0d66158 into herman/scep-provisioner-decrypter Sep 22, 2023
13 checks passed
@hslatman hslatman deleted the herman/scep-notifying-webhook branch September 22, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

Assignees
No one assigned
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hslatman @maraino