Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for identity certificate signing (in sshSign) by skipping validators #1572

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Allow for identity certificate signing (in sshSign) by skipping validators #1572

merged 1 commit into from
Oct 6, 2023

Conversation

dopey
Copy link
Contributor

@dopey dopey commented Oct 6, 2023

  • skip urisValidator for identity certificate signing. Implemented by building the validator with the context in a hacky way.

@dopey
Allow for identity certificate signing (in sshSign) by skipping valid…
83882aa 
…ators

- skip urisValidator for identity certificate signing. Implemented
  by building the validator with the context in a hacky way.
@dopey dopey requested a review from maraino October 6, 2023 06:02
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Oct 6, 2023
maraino
maraino approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we need to refactor this, adding something like an AuthirizeIdentity method in the provisioners that can be used to verify and create the identity certificate.

@dopey dopey merged commit 9f84f7c into master Oct 6, 2023
15 checks passed
@dopey dopey deleted the max/signIdentity branch October 6, 2023 21:02
fritterhoff pushed a commit to hm-edu/pki-acme-service that referenced this pull request Oct 7, 2023
@dopey @fritterhoff
Allow for identity certificate signing (in sshSign) by skipping valid…
ff6a02d 
…ators (smallstep#1572)

- skip urisValidator for identity certificate signing. Implemented
  by building the validator with the context in a hacky way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

Assignees
No one assigned
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dopey @maraino