Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire ACME extensions #1666

Open
wants to merge 179 commits into
base: master
Choose a base branch
from
Open

Wire ACME extensions #1666

wants to merge 179 commits into from
+6,690 −205

Commits on Jan 8, 2024

  1. Add Wire authz and challenges (OIDC+DPOP)

    @stefanwire @hslatman
    stefanwire authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    8e0e355 View commit details
    Browse the repository at this point in the history

  2. update wire challenges' status on happy end

    @stefanwire @hslatman
    stefanwire authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    da1e64a View commit details
    Browse the repository at this point in the history

  3. simplify OIDC verification

    @stefanwire @hslatman
    stefanwire authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    5ca7445 View commit details
    Browse the repository at this point in the history

  4. use json struct for challenge request payload otherwise it's a hell t… 

    …o craft from client side
    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    227e932 View commit details
    Browse the repository at this point in the history

  5. acquire DPoP signing key from provisioner

    @stefanwire @hslatman
    stefanwire authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    e6dd211 View commit details
    Browse the repository at this point in the history

  6. better observability

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    1fe61be View commit details
    Browse the repository at this point in the history

  7. avoid panic when OIDC config is not provided

    @stefanwire @hslatman
    stefanwire authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    2208b03 View commit details
    Browse the repository at this point in the history

  8. print oidc options

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    83f6be1 View commit details
    Browse the repository at this point in the history

  9. fix: challenge is '.token' and not '.id'

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    74ddad6 View commit details
    Browse the repository at this point in the history

  10. avoid manipulating the key PEM format and take a plain PEM key as input

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ca01c74 View commit details
    Browse the repository at this point in the history

  11. fix csr org validation in finalize

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    73ec6c8 View commit details
    Browse the repository at this point in the history

  12. fix csr domain validation in finalize

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    5ba0ab3 View commit details
    Browse the repository at this point in the history

  13. (finalize) have both display name & domain in SANs

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c41a99a View commit details
    Browse the repository at this point in the history

  14. fix orderNames size

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3eb0ff4 View commit details
    Browse the repository at this point in the history

  15. cleanup my mess

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b3dd169 View commit details
    Browse the repository at this point in the history

  16. fix san validation

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    cc5fd0a View commit details
    Browse the repository at this point in the history

  17. change uri prefix to impp:wireapp=

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    01ef526 View commit details
    Browse the repository at this point in the history

  18. skip empty entries for uniqueSortedLowerNames

    @stefanwire @hslatman
    stefanwire authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    af31a16 View commit details
    Browse the repository at this point in the history

  19. feat: adapt to dex and pass the 'keyauth' in payload instead of in id… 

    …_token. Also have a different mapping for id_token claims name
    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b6ec442 View commit details
    Browse the repository at this point in the history

  20. feat: change from impp prefix to just im

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3f474f7 View commit details
    Browse the repository at this point in the history

  21. fix: exclude displayName from SAN DNS

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    79501df View commit details
    Browse the repository at this point in the history

  22. remove displayName validation, potentially harmful

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4172b69 View commit details
    Browse the repository at this point in the history

  23. forward displayName in CSR with custom OID

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3576cc3 View commit details
    Browse the repository at this point in the history

  24. try using google oidc for demo purpose

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a49966f View commit details
    Browse the repository at this point in the history

  25. fix google id token matching in oidc challenge

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    49ad2d9 View commit details
    Browse the repository at this point in the history

  26. infer domain from google email address

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a97991a View commit details
    Browse the repository at this point in the history

  27. adapt google demo for wire's special handle format "{firstname}_wire"

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    680b6ea View commit details
    Browse the repository at this point in the history

  28. fix: add URI prefix to handle

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    7c9f802 View commit details
    Browse the repository at this point in the history

  29. fix: do not convert URIs to lowercase for comparison purpose

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b58de27 View commit details
    Browse the repository at this point in the history

  30. wip

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d32a3e2 View commit details
    Browse the repository at this point in the history

  31. fix: challenge target field was not mapped to db entity

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    9700204 View commit details
    Browse the repository at this point in the history

  32. add oidc target

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    036a144 View commit details
    Browse the repository at this point in the history

  33. simpler

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    2b1223a View commit details
    Browse the repository at this point in the history

  34. passing expected issuer to rusty-jwt-cli

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c4fb19d View commit details
    Browse the repository at this point in the history

  35. Replace field access by accessor functions

    @stefanwire @hslatman
    stefanwire authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    83ba0bd View commit details
    Browse the repository at this point in the history

  36. Reorganize parsing target

    @stefanwire @hslatman
    stefanwire authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    5ceed08 View commit details
    Browse the repository at this point in the history

  37. fix deviceId computing in dpop challenge

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ff41a11 View commit details
    Browse the repository at this point in the history

  38. trying to pass access token to template

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a32bb66 View commit details
    Browse the repository at this point in the history

  39. try silencing template data for dichotomies

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    76dfcb0 View commit details
    Browse the repository at this point in the history

  40. try by storing everything in db

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    abe8600 View commit details
    Browse the repository at this point in the history

  41. Add new Wire DB methods to acme.DB interface

    @hslatman
    hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    1a711e1 View commit details
    Browse the repository at this point in the history

  42. have updateOrder also update the update joint table [order by account]

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    2e12805 View commit details
    Browse the repository at this point in the history

  43. log more things

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    0bc530c View commit details
    Browse the repository at this point in the history

  44. cheat by allowing also looking up for ready orders

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    8888262 View commit details
    Browse the repository at this point in the history

  45. Add GetAllOrdersByAccountID to MockDB

    @hslatman
    hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    0b68e1b View commit details
    Browse the repository at this point in the history

  46. wip

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    613e6ca View commit details
    Browse the repository at this point in the history

  47. fix dpop token json serialization to db

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    03dbd91 View commit details
    Browse the repository at this point in the history

  48. i'm tired

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f5b346e View commit details
    Browse the repository at this point in the history

  49. support for oidc id token

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    7b57401 View commit details
    Browse the repository at this point in the history

  50. Make MockDB implement acme.DB interface again

    @hslatman
    hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ab9e1dd View commit details
    Browse the repository at this point in the history

  51. fix: verify custom display_name extension is present

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    1b32957 View commit details
    Browse the repository at this point in the history

  52. fix: PR review

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    9d5c974 View commit details
    Browse the repository at this point in the history

  53. fix: invalid OID for display name in CSR

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    5fdf036 View commit details
    Browse the repository at this point in the history

  54. fix: access token verification in DPoP challenge. Was previously veri… 

    …fying 'cnf.kid' against backend key whereas it must be against client's key
    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ed2bce9 View commit details
    Browse the repository at this point in the history

  55. client jwk was there the whole time

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4d028f7 View commit details
    Browse the repository at this point in the history

  56. print kid for debugging

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    8fd0192 View commit details
    Browse the repository at this point in the history

  57. b64 encode the kid since apparently it wasn't

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    83f7643 View commit details
    Browse the repository at this point in the history

  58. fix: could not reuse a signing key otherwise it would create in accou… 

    …nts & orders and fail the OIDC challenge. The OIDC challenge was not retryable
    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    13df461 View commit details
    Browse the repository at this point in the history

  59. fix: oups

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ff07fdc View commit details
    Browse the repository at this point in the history

  60. fix: same issue as with oidc challenge

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    2be7738 View commit details
    Browse the repository at this point in the history

  61. feat: remove custom hardcoded OIDC challenge for Google

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    6ffd913 View commit details
    Browse the repository at this point in the history

  62. feat: update the protocol by including team & handle in the client dp… 

    …op token, verifying the handle in the dpop challenge
    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d6ceebb View commit details
    Browse the repository at this point in the history

  63. feat: remove query parameters from OIDC issuerUrl so that it allows u… 

    …s to use it to carry the OAuth ClientId in the Challenge.target field without at the same time undermining the idToken verification which relies on a issuer (iss) claim without this query parameter
    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    39bf889 View commit details
    Browse the repository at this point in the history

  64. feat: try using the new ClientId & Handle format (i.e. plain URIs)

    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    90b5347 View commit details
    Browse the repository at this point in the history

  65. feat: change the separator between user-id & device-id in a client-id… 

    …. Use '!' instead of ':'
    @beltram @hslatman
    beltram authored and hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    84e9682 View commit details
    Browse the repository at this point in the history

  66. Make it compile with Go 1.20 again

    @hslatman
    hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c1a7acc View commit details
    Browse the repository at this point in the history

  67. Fix tests for new ACME orders with Wire IDs

    @hslatman
    hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    fdea5e7 View commit details
    Browse the repository at this point in the history

  68. Fix the integration test

    @hslatman
    hslatman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    85309bb View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Make the Target optional in Challenge object 

    This is a non-standard property in the ACME challenge response, so
we shouldn't return it if it's not set. Also made it an optional
field in the DB.
    @hslatman
    hslatman committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    01169b2 View commit details
    Browse the repository at this point in the history

  2. Refactor WireID target processing a bit

    @hslatman
    hslatman committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    40668ae View commit details
    Browse the repository at this point in the history

  3. Refactor logic for processing WireID identifiers in Order 

    Processing `WireID` identifiers, the Wire subject, and the Wire
DPoP and OIDC tokens is now conditional.
    @hslatman
    hslatman committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    eb9893b View commit details
    Browse the repository at this point in the history

  4. Fix missing DPoP and OIDC tokens for Wire integration test

    @hslatman
    hslatman committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f5a2f43 View commit details
    Browse the repository at this point in the history

  5. Fix linter issues and improve error handling

    @hslatman
    hslatman committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    776a839 View commit details
    Browse the repository at this point in the history

  6. Use require to check for errors in Wire integration test

    @hslatman
    hslatman committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    7a464cd View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Remove the Wire CLI invocatation

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    29fa662 View commit details
    Browse the repository at this point in the history

  2. Make template use DeviceId for now

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    e2a2e00 View commit details
    Browse the repository at this point in the history

  3. fix: keyauth was not bound to the id token

    @beltram @hslatman
    beltram authored and hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    bf5f120 View commit details
    Browse the repository at this point in the history

  4. Change KeyAuth back to old behavior (for now)

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    8faf26c View commit details
    Browse the repository at this point in the history

  5. Fix linter issues

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6a98fea View commit details
    Browse the repository at this point in the history

  6. Merge branch 'wire-acme-extensions' into herman/remove-rusty-cli

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    033aef9 View commit details
    Browse the repository at this point in the history

  7. Remove the Wire oidc and dpop from attestation formats

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    bf8c17e View commit details
    Browse the repository at this point in the history

  8. Disable wire-dpop-01 and wire-oidc-01 by default

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    8997ce1 View commit details
    Browse the repository at this point in the history

  9. Fix tests for ACME Wire provisioner

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    ffd887f View commit details
    Browse the repository at this point in the history

  10. Merge branch 'wire-acme-extensions' into herman/remove-rusty-cli

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a423151 View commit details
    Browse the repository at this point in the history

  11. Remove the rusty-jwt-cli configuration

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    c7892e9 View commit details
    Browse the repository at this point in the history

  12. Change name of test for Wire Order

    @hslatman
    hslatman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    de25740 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Address review remarks

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    70a2f43 View commit details
    Browse the repository at this point in the history

  2. Fix and add more tests to Wire order identifier validation

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    ca88557 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'wire-acme-extensions' into herman/remove-rusty-cli

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    897688a View commit details
    Browse the repository at this point in the history

  4. Fix test for parseAndVerifyWireAccessToken

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    cd9480a View commit details
    Browse the repository at this point in the history

  5. Put Wire options in lower level wire struct

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    acad227 View commit details
    Browse the repository at this point in the history

  6. Add validation of handle and token to Wire verification

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b964c97 View commit details
    Browse the repository at this point in the history

  7. Add verification of maximum expiry time for Wire tokens

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b6fc000 View commit details
    Browse the repository at this point in the history

  8. Refactor the Wire option configuration

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6ef64b6 View commit details
    Browse the repository at this point in the history

  9. Make Wire options more robust

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    1f5f756 View commit details
    Browse the repository at this point in the history

  10. Use base64 encoded signing key format

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    1bf807a View commit details
    Browse the repository at this point in the history

  11. Add Wire DPoP proof claims verification

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    348363a View commit details
    Browse the repository at this point in the history

  12. Remove debug err print

    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    44721a7 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'herman/remove-rusty-cli' into herman/wire-configuration… 

    …-refactor
    @hslatman
    hslatman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    7eacb68 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Change signature algorithm property name

    @hslatman
    hslatman committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    79739e5 View commit details
    Browse the repository at this point in the history

  2. Perform initialization of DPoP and OIDC options once

    @hslatman
    hslatman committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    2479572 View commit details
    Browse the repository at this point in the history

  3. Fix test; reworded error message

    @hslatman
    hslatman committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    c8160ca View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1671 from smallstep/herman/wire-configuration-ref… 

    …actor

Wire ACME extension configuration refactor
    @hslatman
    hslatman committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    3f37fea View commit details
    Browse the repository at this point in the history

  5. Change kid and dpop validation

    @hslatman
    hslatman committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    9bb1b24 View commit details
    Browse the repository at this point in the history

  6. Fix linting issue

    @hslatman
    hslatman committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    2c27e86 View commit details
    Browse the repository at this point in the history

  7. Add OIDC token template transformation

    @hslatman
    hslatman committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    0ad381b View commit details
    Browse the repository at this point in the history

  8. Fix Wire ID token test comment

    @hslatman
    hslatman committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    d5b0d92 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Add support for functions in OIDC token transformation template

    @hslatman
    hslatman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    29202ef View commit details
    Browse the repository at this point in the history

  2. Store transformed OIDC token

    @hslatman
    hslatman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    768a089 View commit details
    Browse the repository at this point in the history

  3. Add tests for Wire OIDC and DPoP token persistence

    @hslatman
    hslatman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    7d5a791 View commit details
    Browse the repository at this point in the history

  4. Fix expected error type check

    @hslatman
    hslatman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    2efd1f6 View commit details
    Browse the repository at this point in the history

  5. Make the Wire API integration test a bit more like the real flow

    @hslatman
    hslatman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    bca179d View commit details
    Browse the repository at this point in the history

  6. Make the example Wire handle consistent

    @hslatman
    hslatman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    c46434f View commit details
    Browse the repository at this point in the history

  7. Add tests for Wire ID parsing

    @hslatman
    hslatman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    a2304c8 View commit details
    Browse the repository at this point in the history

  8. Add test for wireOIDC01Validate

    @hslatman
    hslatman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    d84abac View commit details
    Browse the repository at this point in the history

  9. Add test for wireDPOP01Validate

    @hslatman
    hslatman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    8f129a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Add test case for validateWireOIDCClaims

    @hslatman
    hslatman committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a24b2a5 View commit details
    Browse the repository at this point in the history

  2. Improve test coverage for wireDPOP01Validate

    @hslatman
    hslatman committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    7520736 View commit details
    Browse the repository at this point in the history

  3. Fix Wire integration test by acting on realistic access/dpop token

    @hslatman
    hslatman committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    37106a4 View commit details
    Browse the repository at this point in the history

  4. Improve test coverage for wireOIDC01Validate

    @hslatman
    hslatman committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    99934ec View commit details
    Browse the repository at this point in the history

  5. Add realistic OIDC payload to Wire integration test

    @hslatman
    hslatman committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    7680da7 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    33be552 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'wire-acme-extensions' into herman/remove-rusty-cli

    @hslatman
    hslatman committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    31bba6f View commit details
    Browse the repository at this point in the history

  8. Merge pull request #1673 from smallstep/herman/wire-template-transform 

    Add OIDC token template transformation
    @hslatman
    hslatman committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    17578b5 View commit details
    Browse the repository at this point in the history

  9. Improve access and dpop token validation

    @hslatman
    hslatman committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    0f0f060 View commit details
    Browse the repository at this point in the history

  10. Comment DPoP token checks that fail e2e test (currently)

    @hslatman
    hslatman committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    0a7fe6e View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Fix validations for DPoP client ID, nonce and issuer

    @hslatman
    hslatman committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b925474 View commit details
    Browse the repository at this point in the history

  2. Fix ACME Validate test for Wire DPoP challenge

    @hslatman
    hslatman committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f221232 View commit details
    Browse the repository at this point in the history

  3. Remove sync.Once for Wire configuration validation

    @hslatman
    hslatman committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f150a4f View commit details
    Browse the repository at this point in the history

  4. Improve Wire persistence errors

    @hslatman
    hslatman committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    36e14de View commit details
    Browse the repository at this point in the history

  5. Use key authorization from ID token and handle -> preferred_username

    @hslatman
    hslatman committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2f3819a View commit details
    Browse the repository at this point in the history

  6. Add audience validation to access, dpop and id token

    @hslatman
    hslatman committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    19dbd02 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #1681 from smallstep/herman/fix-wire-extensions 

    Improve access and dpop token validation
    @hslatman
    hslatman committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    51d1270 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #1670 from smallstep/herman/remove-rusty-cli 

    Remove `rusty-jwt-cli`
    @hslatman
    hslatman committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7e6356e View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Add check for empty deviceID in target URI template evaluation

    @hslatman
    hslatman committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6ee0d70 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. fix: use 2 separate identifiers for Wire

    @beltram
    beltram committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    a3de984 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Update acme/order.go 

    Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
    @beltram @hslatman
    beltram and hslatman committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b8eb559 View commit details
    Browse the repository at this point in the history

  2. use switch statement

    @beltram
    beltram committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    9eed61a View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Change URLs used in DPoP template test

    @hslatman
    hslatman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    4d4719a View commit details
    Browse the repository at this point in the history

  2. Fix tests to work with Wire UserID and DeviceID

    @hslatman
    hslatman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    93ba165 View commit details
    Browse the repository at this point in the history

  3. Fix policy check for Wire user and device identifiers

    @hslatman
    hslatman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    a38132a View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1689 from smallstep/beltram/wire-acme-extensions 

    Use two separate Wire identifier types
    @hslatman
    hslatman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    502334f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    675e418 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    a0e4cba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'wire-acme-extensions' into herman/wire-acme-improvements

    @hslatman
    hslatman committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    79943d2 View commit details
    Browse the repository at this point in the history

  3. Move Wire option validation to provisioner initialization

    @hslatman
    hslatman committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    8a9b1b3 View commit details
    Browse the repository at this point in the history

  4. Skip Wire option validation and initialization if not enabled

    @hslatman
    hslatman committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    14e8d47 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Add test for ACME initialization with Wire challenges

    @hslatman
    hslatman committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    19feae5 View commit details
    Browse the repository at this point in the history

  2. Refactor OIDC verifier instantation to happen only once

    @hslatman
    hslatman committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    cd21f8d View commit details
    Browse the repository at this point in the history

  3. Add basic support for OIDC provider instantiation through discovery

    @hslatman
    hslatman committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c579239 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ace27c0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'wire-acme-extensions' into herman/wire-acme-improvements

    @hslatman
    hslatman committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e6d9208 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    92b6191 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'wire-acme-extensions' into herman/wire-acme-improvements

    @hslatman
    hslatman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    37a9f36 View commit details
    Browse the repository at this point in the history

  3. Replace smallstep/assert with stretchr/testify for ACME provisioner

    @hslatman
    hslatman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e153be3 View commit details
    Browse the repository at this point in the history

  4. Fix OIDC target

    @hslatman
    hslatman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ef657d7 View commit details
    Browse the repository at this point in the history

  5. Improve test coverage for Wire authorizations

    @hslatman
    hslatman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c6a6622 View commit details
    Browse the repository at this point in the history

  6. Simplify the DPoP target provider functionality

    @hslatman
    hslatman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2e78301 View commit details
    Browse the repository at this point in the history

  7. Add validation of name in DPoP token

    @hslatman
    hslatman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5d7e533 View commit details
    Browse the repository at this point in the history

  8. Add validation for Wire UserID + DeviceID identifiers

    @hslatman
    hslatman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    138c101 View commit details
    Browse the repository at this point in the history

  9. Add test for OIDC auto discovery configuration

    @hslatman
    hslatman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    745017c View commit details
    Browse the repository at this point in the history

  10. Address review comments

    @hslatman
    hslatman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    194341e View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge pull request #1691 from smallstep/herman/wire-acme-improvements 

    Wire ACME improvements
    @hslatman
    hslatman committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    95fdbc1 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    aaf5a1c View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0a97e1b View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0d4f53f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    364566b View commit details
    Browse the repository at this point in the history

  2. Fix Wire mock CA interface implementation

    @hslatman
    hslatman committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    755ae0b View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1583e53 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    64c5f19 View commit details
    Browse the repository at this point in the history

  2. Improve token validation error messages and use net/url

    @hslatman
    hslatman committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6eb4662 View commit details
    Browse the repository at this point in the history

  3. Fix ACME Wire Order tests

    @hslatman
    hslatman committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c6c2c4a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a136823 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'wire-acme-extensions' of github.com:smallstep/certifica… 

    …tes into wire-acme-extensions
    @hslatman
    hslatman committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    39e179b View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2f38112 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ae62663 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    6646af6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'wire-acme-extensions' of github.com:smallstep/certifica… 

    …tes into wire-acme-extensions
    @hslatman
    hslatman committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d140ffd View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge branch 'master' into wire-acme-extensions

    @hslatman
    hslatman committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7426edb View commit details
    Browse the repository at this point in the history