Beginnings of acmeDB interface #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- more generalized NotFound type rather than the nosql one we were using - if the error is not recognized then the logic in create account will break.
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 77.19% 77.99% +0.80%
==========================================
Files 98 104 +6
Lines 9721 9549 -172
==========================================
- Hits 7504 7448 -56
+ Misses 1811 1725 -86
+ Partials 406 376 -30
Continue to review full report at Codecov.
|
- still needs unit test
maraino
requested changes
Mar 26, 2021
maraino
requested changes
Mar 29, 2021
- always URL escape linker output - validateJWS should accept RSAPSS - GetUpdateAccount -> GetOrUpdateAccount
maraino
reviewed
Apr 13, 2021
acme/db/nosql/nosql.go
Outdated
Comment on lines
89
to
96
| type Clock int | ||
|
|
||
| // Now returns the UTC time rounded to seconds. | ||
| func (c *Clock) Now() time.Time { | ||
| return time.Now().UTC().Round(time.Second) | ||
| } | ||
|
|
||
| var clock = new(Clock) |
There was a problem hiding this comment.
Empty struct and Truncate instead of Round.
maraino
approved these changes
Apr 13, 2021
- NegotiatedProtocolIsMutual is always true: Deprecated according to golang docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.