Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binary-* recipes from Makefile #571

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

tashian
Copy link
Contributor

@tashian tashian commented May 11, 2021

These don't appear to be in use anymore in the step-ca build / release process.
(The same recipe names are still in use in cli release proces, to build & upload S3 binaries. I'm looking into removing those in favor of GoReleaser)

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label May 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #571 (07cf037) into master (f83ccc3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   76.81%   76.81%           
=======================================
  Files         109      109           
  Lines        9819     9819           
=======================================
  Hits         7542     7542           
  Misses       1887     1887           
  Partials      390      390           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83ccc3...07cf037. Read the comment docs.

@tashian tashian requested review from dopey and maraino May 11, 2021 15:02
@tashian tashian merged commit 850b159 into master May 18, 2021
@tashian tashian deleted the carl/makefile-clean branch May 18, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants