Improve ca.Provisioner #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention of this change is to make it usable from cert-manager.
Config package will panic if it cannot create the step path folder.
This reverts commit cc1c6f2.
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
===========================================
- Coverage 79.65% 68.47% -11.18%
===========================================
Files 36 39 +3
Lines 3038 3607 +569
===========================================
+ Hits 2420 2470 +50
- Misses 461 982 +521
+ Partials 157 155 -2
Continue to review full report at Codecov.
|
dopey
approved these changes
Jun 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type
ca.Provisioneris used by some projects to generate tokens for a JWK provisioner. This PR adds some flexibility in the construction so it does depends on files, and []byte can be used to set the root CA.