Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attribute to disable SSH Hosts list API #989

Merged
merged 2 commits into from Aug 8, 2022
Merged

Add attribute to disable SSH Hosts list API #989

merged 2 commits into from Aug 8, 2022

Conversation

dopey
Copy link
Contributor

@dopey dopey commented Jul 28, 2022

Fixes #981

@dopey dopey requested review from maraino and hslatman July 28, 2022 06:31
@dopey dopey self-assigned this Jul 28, 2022
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jul 28, 2022
@hslatman
Copy link
Member

lgtm!

maraino
maraino requested changes Aug 4, 2022
View reviewed changes
authority/config/config.go Outdated Show resolved Hide resolved
@dopey dopey requested a review from maraino August 5, 2022 01:45
maraino
maraino approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maraino maraino added this to the Next Release milestone Aug 8, 2022
@dopey dopey merged commit 3e2729e into master Aug 8, 2022
@dopey dopey deleted the max/disable-ssh-hosts branch August 8, 2022 21:15
@nodakai
Copy link

nodakai commented Nov 9, 2022

Wonder if you could keep it open only for legitimate users? If hiding them is opt-in, few would bother to find the config and turn it on.

I'm a little nervous after observing somebody hitting /ssh/check-host on my (test) installation repeatedly (even when getting any info from it might be as difficult as cracking SSH). Yeah I should have collected their IP addresses but I was using Rootless Podman with a weird NAT that loses source addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

@hslatman hslatman hslatman approved these changes

Assignees

@dopey dopey

Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.

[Bug]: curl server.com/ssh/hosts
4 participants
@dopey @hslatman @nodakai @maraino