fix ineffectual assignment error

smallstep · Nov 16, 2018 · 5db90e2 · 5db90e2
1 parent 93aa6d6
commit 5db90e2
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/command/crypto/key/format.go b/command/crypto/key/format.go
@@ -105,6 +105,9 @@ func formatAction(ctx *cli.Context) error {
 		default:
 			return errors.Errorf("Unsupoorted key type %T", key)
 		}
+		if err != nil {
+			return err
+		}
 	default: // assuming DER format
 		// Attempt to parse first as a PKCS8 formatted private key.
 		key, err := x509.ParsePKCS8PrivateKey(b)
@@ -124,10 +127,6 @@ func formatAction(ctx *cli.Context) error {
 		ob = pem.EncodeToMemory(p)
 	}
 
-	if err != nil {
-		return err
-	}
-
 	if out == "" {
 		os.Stdout.Write(ob)
 	} else {