Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies, fix linting issues and add client request ID #1120

Merged
merged 3 commits into from Mar 5, 2024

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Mar 4, 2024

Replaces:

#1119
#1118
#1117
#1116

With the latest version of certificates in step, a request ID is automatically sent from the client:

...
INFO[7726] duration="72.417µs" duration-ns=72417 fields.time="2024-03-04T22:24:26+01:00" method=GET name=ca path=/health protocol=HTTP/2.0 referer= remote-address=127.0.0.1 request-id=d031fe60-a716-45d9-b84f-5af73b1cc442 size=16 status=200 user-agent="Smallstep CLI/0000000-dev (darwin/arm64)" user-id=
...

And on the client side:

GODEBUG=http2debug=2 step ca health 
2024/03/04 22:24:26 http2: Transport failed to get client conn for 127.0.0.1:8443: http2: no cached connection was available
2024/03/04 22:24:26 http2: Transport creating client conn 0x14000274300 to 127.0.0.1:8443
2024/03/04 22:24:26 http2: Framer 0x140005402a0: wrote SETTINGS len=18, settings: ENABLE_PUSH=0, INITIAL_WINDOW_SIZE=4194304, MAX_HEADER_LIST_SIZE=10485760
2024/03/04 22:24:26 http2: Framer 0x140005402a0: wrote WINDOW_UPDATE len=4 (conn) incr=1073741824
2024/03/04 22:24:26 http2: Transport encoding header ":authority" = "127.0.0.1:8443"
2024/03/04 22:24:26 http2: Transport encoding header ":method" = "GET"
2024/03/04 22:24:26 http2: Transport encoding header ":path" = "/health"
2024/03/04 22:24:26 http2: Transport encoding header ":scheme" = "https"
2024/03/04 22:24:26 http2: Transport encoding header "user-agent" = "Smallstep CLI/0000000-dev (darwin/arm64)"
2024/03/04 22:24:26 http2: Transport encoding header "x-request-id" = "d031fe60-a716-45d9-b84f-5af73b1cc442"
2024/03/04 22:24:26 http2: Transport encoding header "accept-encoding" = "gzip"
2024/03/04 22:24:26 http2: Framer 0x140005402a0: wrote HEADERS flags=END_STREAM|END_HEADERS stream=1 len=96
2024/03/04 22:24:26 http2: Framer 0x140005402a0: read SETTINGS len=30, settings: MAX_FRAME_SIZE=1048576, MAX_CONCURRENT_STREAMS=250, MAX_HEADER_LIST_SIZE=1048896, HEADER_TABLE_SIZE=4096, INITIAL_WINDOW_SIZE=1048576
2024/03/04 22:24:26 http2: Transport received SETTINGS len=30, settings: MAX_FRAME_SIZE=1048576, MAX_CONCURRENT_STREAMS=250, MAX_HEADER_LIST_SIZE=1048896, HEADER_TABLE_SIZE=4096, INITIAL_WINDOW_SIZE=1048576
2024/03/04 22:24:26 http2: Framer 0x140005402a0: wrote SETTINGS flags=ACK len=0
2024/03/04 22:24:26 http2: Framer 0x140005402a0: read WINDOW_UPDATE len=4 (conn) incr=983041
2024/03/04 22:24:26 http2: Transport received WINDOW_UPDATE len=4 (conn) incr=983041
2024/03/04 22:24:26 http2: Framer 0x140005402a0: read SETTINGS flags=ACK len=0
2024/03/04 22:24:26 http2: Transport received SETTINGS flags=ACK len=0
2024/03/04 22:24:26 http2: Framer 0x140005402a0: read HEADERS flags=END_HEADERS stream=1 len=80
2024/03/04 22:24:26 http2: decoded hpack field header field ":status" = "200"
2024/03/04 22:24:26 http2: decoded hpack field header field "content-type" = "application/json"
2024/03/04 22:24:26 http2: decoded hpack field header field "x-request-id" = "d031fe60-a716-45d9-b84f-5af73b1cc442"
2024/03/04 22:24:26 http2: decoded hpack field header field "content-length" = "16"
2024/03/04 22:24:26 http2: decoded hpack field header field "date" = "Mon, 04 Mar 2024 21:24:26 GMT"
2024/03/04 22:24:26 http2: Transport received HEADERS flags=END_HEADERS stream=1 len=80
2024/03/04 22:24:26 http2: Framer 0x140005402a0: read DATA flags=END_STREAM stream=1 len=16 data="{\"status\":\"ok\"}\n"
2024/03/04 22:24:26 http2: Transport received DATA flags=END_STREAM stream=1 len=16 data="{\"status\":\"ok\"}\n"
ok

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Mar 4, 2024
@hslatman hslatman added this to the v0.25.3 milestone Mar 4, 2024
@hslatman hslatman requested a review from a team March 4, 2024 21:13
@hslatman hslatman changed the title Upgrade dependencies and fix linting issues Upgrade dependencies, fix linting issues and add client request ID Mar 4, 2024
@hslatman hslatman merged commit eeb3d87 into master Mar 5, 2024
15 checks passed
@hslatman hslatman deleted the herman/upgrade-dependencies-20240304 branch March 5, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants