Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow empty password in step cert create ... #393

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Do not allow empty password in step cert create ... #393

merged 1 commit into from
Nov 30, 2020

Conversation

dopey
Copy link
Contributor

@dopey dopey commented Nov 26, 2020

  • unless --no-password --insecure used

Fixes #379

@dopey
Do not allow empty password in step cert create ...
1e2fbb0 
- unless --no-password --insecure used
@dopey dopey added the bug fix Pull Request that fixes a bug label Nov 26, 2020
@dopey dopey requested a review from maraino November 26, 2020 19:07
@dopey dopey self-assigned this Nov 26, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020 •
edited

Codecov Report

Merging #393 (1e2fbb0) into master (df41f64) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   63.90%   63.89%   -0.01%     
==========================================
  Files          56       56              
  Lines        6691     6692       +1     
==========================================
  Hits         4276     4276              
- Misses       2189     2190       +1     
  Partials      226      226
Impacted Files Coverage Δ
command/certificate/create.go 55.29% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df41f64...1e2fbb0. Read the comment docs.

maraino
maraino approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dopey dopey merged commit 7951724 into master Nov 30, 2020
@dopey dopey deleted the max/cert-create-no-empty-pass branch October 10, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

Assignees

@dopey dopey

Labels
bug fix Pull Request that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

step certificate create should warn that an empty password was used to encrypt private key
2 participants
@dopey @maraino