Use google.golang.org/grpc v1.29.1 to fix a dependency issue #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go.etcd.io/etcd depends on deprecated packages of gRPC that have been removed. This causes that go mod cannot build the dependency tree and utilities like `go mod tidy` or `go mod vendor` does not work properly. This fix uses a gRPC version that supports old and new interfaces. So it can be used by etcd and google cloud packages. Fixes #377
dopey
reviewed
Dec 1, 2020
go.mod
Outdated
| gopkg.in/square/go-jose.v2 v2.5.1 | ||
| software.sslmate.com/src/go-pkcs12 v0.0.0-20201103104416-57fc603b7f52 | ||
| ) | ||
|
|
||
| // This is a temporal workaround to fix a dependency problem between etcd and | ||
| // gRPC. The gRPC v1.29.1 supports old a new interfaces, so it can be used by |
dopey
approved these changes
Dec 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
==========================================
- Coverage 63.89% 62.92% -0.98%
==========================================
Files 56 56
Lines 6692 6993 +301
==========================================
+ Hits 4276 4400 +124
- Misses 2190 2367 +177
Partials 226 226
Continue to review full report at Codecov.
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
go.etcd.io/etcd depends on deprecated packages of gRPC that have been removed. This causes that go mod cannot build the dependency tree, and utilities like
go mod tidyorgo mod vendordoes not work properly.This fix uses a gRPC version that supports old and new interfaces. So it can be used by etcd and google cloud packages.
Fixes #377