Add options for specifying the subscription and object IDs with the Azure Provisioner #642
Conversation
github-actions
bot
added
the
needs triage
| azureSubscriptionIDFlag, | ||
| removeAzureSubscriptionIDFlag, | ||
| azureObjectIDFlag, | ||
| removeAzureObjectIDFlag, |
There was a problem hiding this comment.
I don't see these flags taken into account in the updateAzureDetails function.
There was a problem hiding this comment.
Hi @vijayjt, I think there's a small problem with the flags to update parameters, they should not include the add- prefix.
I'm going to merge the changes and create another PR to fix all of those, because it looks like GCP, AWS and existing Azure flags have the same problem.
command/ca/provisionerbeta/update.go
Outdated
| if ctx.IsSet("azure-resource-group") { | ||
| details.ResourceGroups = append(details.ResourceGroups, ctx.StringSlice("add-azure-resource-group")...) | ||
| } | ||
| if ctx.IsSet("remove-azure-subscription-id") { | ||
| details.SubscriptionIds = removeElements(details.SubscriptionIds, ctx.StringSlice("remove-azure-subscription-id")) | ||
| } | ||
| if ctx.IsSet("azure-subscription-id") { | ||
| details.SubscriptionIds = append(details.SubscriptionIds, ctx.StringSlice("add-azure-subscription-id")...) | ||
| } | ||
| if ctx.IsSet("remove-azure-object-id") { | ||
| details.ObjectIds = removeElements(details.ObjectIds, ctx.StringSlice("remove-azure-object-id")) | ||
| } | ||
| if ctx.IsSet("azure-object-id") { | ||
| details.ObjectIds = append(details.ObjectIds, ctx.StringSlice("add-azure-object-id")...) | ||
| } |
There was a problem hiding this comment.
I think the flags are:
azure-subscription-idinstead ofadd-azure-subscription-idazure-object-idinstead ofadd-azure-object-id
And the same might happen in add-azure-resource-group.
There was a problem hiding this comment.
In fact, after looking at the code, the same happens for:
add-gcp-service-accountadd-gcp-projectadd-aws-account- and of course
add-azure-resource-group
|
I'll push directly to your repo and merge everything together. |
|
@maraino Awesome - thanks for making those changes for me and for reviewing and getting my PRs merged in - much appreciated! |
This PR is related to this issue in the certificates repo:
It adds command line options for the Azure Provisioner to allow the user to specify the subscription IDs and/or object IDs that can request certificates.
Here are the corresponding PRs in the certificates repo and the linked ca repo.