Upgrade go-tpm and adapt imports to use the legacy version
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we'll have to wait till Go 1.21 is released, so that we can drop Go 1.19 support: https://github.com/smallstep/crypto/actions/runs/5388813488/jobs/9781946300. The change was introduced with google/go-tpm@5115077. Alternatively, since the only code paths that go through |
This was referenced Jun 27, 2023
|
After the Go version was upgraded to 1.20, the GH action now completes successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of
go-tpmwas released that changes the public API of thetpm2package. Thelegacy/tpm2contains the functions we used, so imports were adapted to use that, similar to what's done in other Google repos relying ongo-tpm.The TPMDirect interface that was released with it should provide us a more pleasant and simpler approach for interfacing with the TPM, so I'll look into migrating our usage to that soon.