Migrate to github.com/aws/aws-sdk-go-v2 #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR migrates the awskms implementation to the v2 of AWS SDK. Fixes #405
hslatman
reviewed
Jan 19, 2024
kms/awskms/awskms_test.go
Outdated
Comment on lines
367
to
369
| {"SHA512WithRSA+2048", args{apiv1.SHA256WithRSA, 2048}, types.KeySpecRsa2048, assert.NoError}, | ||
| {"SHA512WithRSA+3072", args{apiv1.SHA256WithRSA, 3072}, types.KeySpecRsa3072, assert.NoError}, | ||
| {"SHA512WithRSA+4096", args{apiv1.SHA256WithRSA, 4096}, types.KeySpecRsa4096, assert.NoError}, |
There was a problem hiding this comment.
I think those should have apiv1.SHA512WithRSA for the names to match??
There was a problem hiding this comment.
Copy paste. They succeed because AWS is not like GCP, and you can use the same key for different types of signatures. Fixed with 3404685
kms/awskms/awskms_test.go
Outdated
Comment on lines
375
to
377
| {"SHA512WithRSAPSS+2048", args{apiv1.SHA256WithRSA, 2048}, types.KeySpecRsa2048, assert.NoError}, | ||
| {"SHA512WithRSAPSS+3072", args{apiv1.SHA256WithRSA, 3072}, types.KeySpecRsa3072, assert.NoError}, | ||
| {"SHA512WithRSAPSS+4096", args{apiv1.SHA256WithRSA, 4096}, types.KeySpecRsa4096, assert.NoError}, |
There was a problem hiding this comment.
Those too should have SHA512WithRSA?
hslatman
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the awskms implementation to the v2 of AWS SDK.
Fixes #405