Add support validities in templates #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows setting the validity bounds on X.509 and SSH certificates using templates.
maraino
force-pushed
the
mariano/validity
branch
from
dfd1fab
to
c298af8
Compare
toTime formats a time or a Unix epoch to RFC3339, the format used to unmarshal a string to a time.Time.
maraino
changed the title
1 task
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
hslatman
previously approved these changes
Jul 1, 2024
|
That lint issue is my bad with the GH editor |
hslatman
approved these changes
Jul 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit allows setting the validity bounds on X.509 and SSH certificates using templates.
It also adds the template method
toTime, which makes it easier to format a timestamp to RFC3339. This format is compatible with Go'stime.Timewhenjson.Unmarshalis used. There are similar methods to do this in the sprig library, but they require you to specify the format string. For example, these methods will return a valid string that can be unmarshaled totime.Time:{{ date "2006-01-02T15:04:05Z07:00" .Token.nbf | toJson }} {{ dateInZone "2006-01-02T15:04:05Z07:00" .Token.nbf "UTC" | toJson }} {{ toTime .Token.nbf | toJson }}