Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade k8s.io/client-go and sigs.k8s.io/controller-runtime #185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hslatman
Copy link
Member

Replaces #181 and #180

@hslatman hslatman requested review from maraino and a team as code owners April 29, 2024 08:01
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Apr 29, 2024
@dopey
Copy link
Contributor

dopey commented Apr 29, 2024

Not sure how we want to proceed with these PRs in the short term. Historically, we have committed to fully supporting the latest two version of golang in open source projects. But this PR would change the go version in go.mod to 1.22.0, which could mean losing support for v1.21.

@hslatman
Copy link
Member Author

Yes, that's fair. The apimachinery dependency requires Go 1.22 now, so that's why it was bumped in the Dependabot PRs and failed. We would have to put Dependabot to sleep for a while for that minor version, and possibly related PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants