fix on ssl certs auto-renew [issue #24] #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dophy6 thanks for creating this! I'll test and review as soon as I can. |
smallwat3r
requested changes
Dec 2, 2022
There was a problem hiding this comment.
Thanks for submitting this PR, and sorry for delay to review it!
I was able to test this on one of my servers, and this seems to be working like a charm. Great investigation work!
Requesting a few changes regarding formatting, and I think this will be good to go 🎉
| @@ -2,7 +2,8 @@ | |||
| FROM nginx:1.19-alpine | |||
|
|
|||
| # Install certbot for letsencrypt certificates | |||
| RUN apk add --no-cache certbot | |||
| # Install also an init handler for alpine cron | |||
| RUN apk add --no-cache certbot openrc busybox-initscripts | |||
Co-authored-by: Matthieu Petiteau <matt@smallwat3r.com>
Co-authored-by: Matthieu Petiteau <matt@smallwat3r.com>
|
Hi @smallwat3r I accepted all your suggestions, hoping this will help the community, have a nice day! |
smallwat3r
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #24
There was a blocking call to nginx in entrypoint.sh file before the execution of
crond -f. Also there were some missing packages to make alpine crons work in Dockerfile.