code review

smalot · Nov 26, 2015 · 1adcc0e · 1adcc0e
1 parent 4d555ee
commit 1adcc0e
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 8 deletions.
diff --git a/lib/Cerbere/Action/ActionInterface.php b/lib/Cerbere/Action/ActionInterface.php
@@ -23,6 +23,7 @@
 
 use Cerbere\Event\DispatcherAwareInterface;
 use Cerbere\Model\Project;
+use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 
 /**
  * Interface ActionInterface
@@ -46,4 +47,10 @@ public function prepare();
      * @return array
      */
     public function process(array $projects, $options = array());
+
+    /**
+     * @param \Symfony\Component\EventDispatcher\EventSubscriberInterface $listener
+     * @return void
+     */
+    public function addLoggerListener(EventSubscriberInterface $listener);
 }
diff --git a/lib/Cerbere/Action/Hacked.php b/lib/Cerbere/Action/Hacked.php
@@ -39,6 +39,11 @@
  */
 class Hacked implements ActionInterface
 {
+    /**
+     * @var EventDispatcherInterface
+     */
+    protected $dispatcher;
+
     /**
      * @inheritDoc
      */
@@ -48,7 +53,7 @@ public function getCode()
     }
 
     /**
-     * @param EventSubscriberInterface $listener
+     * @inheritDoc
      */
     public function addLoggerListener(EventSubscriberInterface $listener)
     {

diff --git a/lib/Cerbere/Action/Update.php b/lib/Cerbere/Action/Update.php
@@ -58,7 +58,7 @@ public function __construct()
     }
 
     /**
-     * @param EventSubscriberInterface $listener
+     * @inheritDoc
      */
     public function addLoggerListener(EventSubscriberInterface $listener)
     {

diff --git a/lib/Cerbere/Model/Hacked/HackedProjectWebDownloader.php b/lib/Cerbere/Model/Hacked/HackedProjectWebDownloader.php
@@ -42,7 +42,7 @@ protected function getTempDirectory($namespace = null)
             $dir .= DIRECTORY_SEPARATOR . preg_replace('/[^0-9A-Z\-_]/i', '', $namespace);
         }
 
-        @mkdir($dir, 0775, true);
+        mkdir($dir, 0775, true);
 
         return $dir;
     }
@@ -60,7 +60,7 @@ protected function getDestination()
         $dir = $this->getTempDirectory() . DIRECTORY_SEPARATOR . $type . DIRECTORY_SEPARATOR . $name;
 
         // Build the destination folder tree if it doesn't already exists.
-        @mkdir($dir, 0775, true);
+        mkdir($dir, 0775, true);
 
         return $dir . DIRECTORY_SEPARATOR . $version;
     }
@@ -97,7 +97,7 @@ public function downloadFile()
     protected function removeDir($path)
     {
         if (is_file($path) || is_link($path)) {
-            @unlink($path);
+            unlink($path);
         } elseif (is_dir($path)) {
             $d = dir($path);
 
@@ -110,7 +110,7 @@ protected function removeDir($path)
             }
 
             $d->close();
-            @rmdir($path);
+            rmdir($path);
         }
     }
 }
diff --git a/lib/Cerbere/Model/Hacked/HackedProjectWebFilesDownloader.php b/lib/Cerbere/Model/Hacked/HackedProjectWebFilesDownloader.php
@@ -48,7 +48,7 @@ public function downloadFile()
         }
 
         // Build the destination folder tree if it doesn't already exists.
-        @mkdir($destination, 0775, true);
+        mkdir($destination, 0775, true);
 
         if (!($local_file = $this->getFile($release_url))) {
             return false;
@@ -92,7 +92,7 @@ protected function getFile($url)
         $local = $cache_directory . DIRECTORY_SEPARATOR . basename($parsed_url['path']);
 
         if (!file_exists($cache_directory)) {
-            @mkdir($cache_directory, 0775, true);
+            mkdir($cache_directory, 0775, true);
         }
 
         // Todo: use guzzle.