Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added macro expansion for redefined Win32 functions #23

Conversation

smalti
Copy link
Owner

@smalti smalti commented Oct 18, 2023

What was done:

Copy link
Collaborator

@Alex0vSky Alex0vSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what else to improve.
I've run out of all the bugs. This is probably good.
Can I do checks in CI from GitHubAction? I understand this a little.

include/gmock-win32.h Show resolved Hide resolved
@smalti
Copy link
Owner Author

smalti commented Oct 19, 2023

Can I do checks in CI from GitHubAction? I understand this a little.

Yes, it's a good idea, we require CI for writing and executing tests.

@smalti
Copy link
Owner Author

smalti commented Oct 19, 2023

I don't know what else to improve. I've run out of all the bugs. This is probably good.

Here are some thoughts on what we can improve:

  • We need to consider adding support for CMake
  • Think about supporting the Linux platform by patching PLT/GOT (but this is quite a big and not easy task)

@smalti smalti merged commit f94ecbe into main Oct 19, 2023
@smalti smalti deleted the 22-macro-expansion-for-winapi-proxied-when-implementing-a-64-bit-architecture branch October 19, 2023 07:14
@Alex0vSky
Copy link
Collaborator

Alex0vSky commented Oct 19, 2023

  • We need to consider adding support for CMake

not clear... can you be more specific please?

  • Think about supporting the Linux platform by patching PLT/GOT (but this is quite a big and not easy task)

Interesting,
have experience in patching executable files of ELF format 😃
Long time ago ... SUSE Linux and Eclipse IDE or KDevelop ... I missed the deadline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro expansion for WinApi, proxied when implementing a 64-bit architecture
2 participants