Skip to content

Commit

Permalink
Remove SetRouter injection
Browse files Browse the repository at this point in the history
  • Loading branch information
bogh committed May 20, 2016
1 parent a2cd35a commit 50f0269
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 55 deletions.
2 changes: 1 addition & 1 deletion scripts/generate_mocks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ MOCKGEN=$GOPATH/bin/mockgen
$MOCKGEN -self_package server -package server \
-destination server/mocks_server_gen_test.go \
github.com/smancke/guble/server \
PubSubSource,MessageSink,WSConnection,Startable,Stopable,SetRouter,SetMessageEntry,Endpoint
PubSubSource,MessageSink,WSConnection,Startable,Stopable,SetMessageEntry,Endpoint
replace "server/mocks_server_gen_test.go" "server \"github.com\/smancke\/guble\/server\"" "server\."

$MOCKGEN -self_package server -package server \
Expand Down
5 changes: 0 additions & 5 deletions server/interfaces.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,6 @@ type Stopable interface {
Stop() error
}

// SetRouter interface for modules which require a `Router`
type SetRouter interface {
SetRouter(router PubSubSource)
}

// SetMessageEntry interface for modules which need a MessageEntry set
type SetMessageEntry interface {
SetMessageEntry(messageSink MessageSink)
Expand Down
31 changes: 1 addition & 30 deletions server/mocks_server_gen_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Automatically generated by MockGen. DO NOT EDIT!
// Source: github.com/smancke/guble/server (interfaces: PubSubSource,MessageSink,WSConnection,Startable,Stopable,SetRouter,SetMessageEntry,Endpoint)
// Source: github.com/smancke/guble/server (interfaces: PubSubSource,MessageSink,WSConnection,Startable,Stopable,SetMessageEntry,Endpoint)

package server

Expand Down Expand Up @@ -227,35 +227,6 @@ func (_mr *_MockStopableRecorder) Stop() *gomock.Call {
return _mr.mock.ctrl.RecordCall(_mr.mock, "Stop")
}

// Mock of SetRouter interface
type MockSetRouter struct {
ctrl *gomock.Controller
recorder *_MockSetRouterRecorder
}

// Recorder for MockSetRouter (not exported)
type _MockSetRouterRecorder struct {
mock *MockSetRouter
}

func NewMockSetRouter(ctrl *gomock.Controller) *MockSetRouter {
mock := &MockSetRouter{ctrl: ctrl}
mock.recorder = &_MockSetRouterRecorder{mock}
return mock
}

func (_m *MockSetRouter) EXPECT() *_MockSetRouterRecorder {
return _m.recorder
}

func (_m *MockSetRouter) SetRouter(_param0 PubSubSource) {
_m.ctrl.Call(_m, "SetRouter", _param0)
}

func (_mr *_MockSetRouterRecorder) SetRouter(arg0 interface{}) *gomock.Call {
return _mr.mock.ctrl.RecordCall(_mr.mock, "SetRouter", arg0)
}

// Mock of SetMessageEntry interface
type MockSetMessageEntry struct {
ctrl *gomock.Controller
Expand Down
8 changes: 1 addition & 7 deletions server/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,11 @@ func NewService(addr string, kvStore store.KVStore, messageStore store.MessageSt
return service
}

// Registers the supplied module on this service.
// Register the supplied module on this service.
// This method checks the module for the following interfaces and
// does the expected tegistrations:
// Stopable: notify when the service stops
// Endpoint: Register the handler function of the Endpoint in the http service at prefix
// SetRouter: Provide the router
// SetMessageEntry: Provide the message entry
//
// If the module does not have a HandlerFunc, the prefix parameter is ignored
Expand All @@ -77,11 +76,6 @@ func (service *Service) Register(module interface{}) {

// do the injections ...

if m, ok := module.(SetRouter); ok {
guble.Debug("inject Router to %v", name)
m.SetRouter(service.router)
}

if m, ok := module.(SetMessageEntry); ok {
guble.Debug("inject MessageEntry to %v", name)
m.SetMessageEntry(service.messageSink)
Expand Down
5 changes: 1 addition & 4 deletions server/service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,13 @@ func TestRegistrationOfSetter(t *testing.T) {
defer initCtrl(t)()

// given:
service, _, _, messageSink, router := aMockedService()
setRouterMock := NewMockSetRouter(ctrl)
service, _, _, messageSink, _ := aMockedService()
setMessageEntryMock := NewMockSetMessageEntry(ctrl)

// then I expect
setRouterMock.EXPECT().SetRouter(router)
setMessageEntryMock.EXPECT().SetMessageEntry(messageSink)

// when I register the modules
service.Register(setRouterMock)
service.Register(setMessageEntryMock)
}

Expand Down
8 changes: 0 additions & 8 deletions server/websocket_connector.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,6 @@ func (handle *WSHandler) SetMessageEntry(messageSink MessageSink) {
handle.MessageSink = messageSink
}

func (handle *WSHandler) SetRouter(router PubSubSource) {
handle.Router = router
}

func (entry *WSHandler) SetAccessManager(accessManager auth.AccessManager) {
entry.accessManager = accessManager
}

func (handle *WSHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
c, err := webSocketUpgrader.Upgrade(w, r, nil)
if err != nil {
Expand Down

0 comments on commit 50f0269

Please sign in to comment.