Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pilet update Check #327

Closed
3 tasks done
FlorianRappl opened this issue Oct 5, 2020 · 1 comment
Closed
3 tasks done

Improve pilet update Check #327

FlorianRappl opened this issue Oct 5, 2020 · 1 comment
Assignees
@FlorianRappl
Labels
bug Something isn't working cli Concerns the piral-cli application.
Milestone
0.12.3

Comments

@FlorianRappl
Copy link
Contributor

Prerequisites

  • Can you reproduce the problem in a MWE?
  • Are you running the latest version?
  • Did you perform a search in the issues?

Environment Details and Version

Piral 0.12.2, new pilet for sample-piral, MacOSX / WSL (Ubuntu) in Windows 10

Description

The initial checks / requirements for running pilet upgrade are insufficient and could be improved. See below for details.

Steps to Reproduce

  1. Shift sample-piral from devDependencies to dependencies in the pilet's package.json
  2. Run pilet update

Expected behavior

Either it "just works" (moving the package again back to devDependencies) or it will complain, remarking that the dependency was found in dependencies, but expected in devDependencies.

Actual behavior

Just complains that it cannot find the app shell instance.

Possible Origin / Solution

I guess we should improve the checks in the update-pilet app / command.
@FlorianRappl FlorianRappl added bug Something isn't working cli Concerns the piral-cli application. labels Oct 5, 2020
@FlorianRappl FlorianRappl added this to the 0.12.3 milestone Oct 5, 2020
@FlorianRappl FlorianRappl self-assigned this Oct 5, 2020
@FlorianRappl FlorianRappl added the in-implementation The item is currently being implemented. label Oct 5, 2020
FlorianRappl added a commit that referenced this issue Oct 5, 2020
@FlorianRappl
Reconsider use of dependencies for pilet upgrade #327
2a8c8b5
@FlorianRappl FlorianRappl added in-testing The item is already out in preview and can be tested. and removed in-implementation The item is currently being implemented. labels Oct 5, 2020
@FlorianRappl
Copy link
Contributor Author

Landed in develop and the preview version @next.

@FlorianRappl FlorianRappl removed the in-testing The item is already out in preview and can be tested. label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlorianRappl FlorianRappl

Labels
bug Something isn't working cli Concerns the piral-cli application.
Projects
None yet
Milestone
0.12.3
Development

No branches or pull requests
1 participant
@FlorianRappl