Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packed pilet has duplicated entries #608

Closed
3 tasks done
daniel-rck opened this issue Jun 23, 2023 · 3 comments
Closed
3 tasks done

Packed pilet has duplicated entries #608

daniel-rck opened this issue Jun 23, 2023 · 3 comments
Labels
bug Something isn't working cli Concerns the piral-cli application. cross-platform Issues that only appear on certain platforms (e.g., Windows).
Milestone
1.0.2

Comments

@daniel-rck
Copy link
Contributor

Bug Report

For more information, see the CONTRIBUTING guide.

Prerequisites

  • Can you reproduce the problem in a MWE
  • Are you running the latest version?
  • Did you perform a search in the issues?

Environment Details and Version

  • Windows 11 22H2
  • node 18.14.0
  • npm 9.5.0
  • piral-cli 1.0.1

Description

When I pack the pilet as tar file, die included files in /package/dist are there twice.

Steps to Reproduce

(See the MWE)

  1. npm i
  2. npm run build
  3. pilet pack

Expected behavior

Every file from dist packed once.

Actual behavior

Every file from dist packed twice.

Possible Origin/Solution

Maybe a OS-dependent issue? Case-Sensitivity?
@daniel-rck daniel-rck added the bug Something isn't working label Jun 23, 2023
@FlorianRappl FlorianRappl added cli Concerns the piral-cli application. cross-platform Issues that only appear on certain platforms (e.g., Windows). labels Jun 23, 2023
@FlorianRappl
Copy link
Contributor

I think we already ruled out the case sensitivity on this one. I'll see when / under what circumstances this can be reproduced and what is the root cause.

I'll come back on this one.

@FlorianRappl FlorianRappl added the in-review The item is currently being reviewed. label Jun 23, 2023
@FlorianRappl FlorianRappl added this to the 1.0.2 milestone Jun 23, 2023
@FlorianRappl FlorianRappl added in-implementation The item is currently being implemented. and removed in-review The item is currently being reviewed. labels Jun 25, 2023
FlorianRappl added a commit that referenced this issue Jun 25, 2023
@FlorianRappl
Fixed issue resulting in duplicated files #608
d19e7b6
@FlorianRappl FlorianRappl added in-testing The item is already out in preview and can be tested. and removed in-implementation The item is currently being implemented. labels Jun 25, 2023
@FlorianRappl
Copy link
Contributor

Thanks for the repo - we could reproduce this. Fix is out in the preview (tag next on npm).

@daniel-rck
Copy link
Contributor Author

Thanks for the quick fix, works as expected!

@FlorianRappl FlorianRappl removed the in-testing The item is already out in preview and can be tested. label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cli Concerns the piral-cli application. cross-platform Issues that only appear on certain platforms (e.g., Windows).
Projects
None yet
Milestone
1.0.2
Development

No branches or pull requests
2 participants
@FlorianRappl @daniel-rck