Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Integration of ADAL #81

Closed
FlorianRappl opened this issue Oct 21, 2019 · 1 comment
Closed

Simplify Integration of ADAL #81

FlorianRappl opened this issue Oct 21, 2019 · 1 comment
Assignees
@FlorianRappl
Labels
auth Concerns plugin that deal with authentication and authorization, core Concerns the piral-core library. enhancement New feature or request plugin Covered by an opt-in plugin for Piral.
Milestone
0.9.0

Comments

@FlorianRappl
Copy link
Contributor

Description

Right now we have piral-auth a plugin that establishes a user object. However, it does not directly deal with authorization / authentication. We should provide some premade solutions (in form of plugins) for dealing with popular providers. Microsoft's Active Directory is a quite popular way - we should support it directly.

Background

Microsoft released several libraries for dealing with AD authentication from JS. The latest version is called MSAL.js.

Potentially, just wrapping the plugin and exposing it via some actions. An integration with, e.g., fetch or urql would be superb (e.g., indirectly via events) to ensure a valid token is provided if necessary.

Discussion

Configuration etc. should just be taken / extended from the original. What other solutions (generic OAuth 2? or already OIDC?) should be available in form of plugins?
@FlorianRappl FlorianRappl added enhancement New feature or request core Concerns the piral-core library. plugin Covered by an opt-in plugin for Piral. auth Concerns plugin that deal with authentication and authorization, labels Oct 21, 2019
@FlorianRappl FlorianRappl added this to the 0.9.0 milestone Nov 13, 2019
@FlorianRappl FlorianRappl added the in-review The item is currently being reviewed. label Nov 13, 2019
@FlorianRappl FlorianRappl self-assigned this Nov 13, 2019
@FlorianRappl FlorianRappl added in-implementation The item is currently being implemented. in-testing The item is already out in preview and can be tested. and removed in-review The item is currently being reviewed. in-implementation The item is currently being implemented. labels Nov 22, 2019
FlorianRappl added a commit that referenced this issue Nov 26, 2019
@FlorianRappl
Improved ADAL plugin #81
ca277f8
@FlorianRappl FlorianRappl removed the in-testing The item is already out in preview and can be tested. label Nov 26, 2019
@FlorianRappl
Copy link
Contributor Author

Landed in the preview / is in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlorianRappl FlorianRappl

Labels
auth Concerns plugin that deal with authentication and authorization, core Concerns the piral-core library. enhancement New feature or request plugin Covered by an opt-in plugin for Piral.
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@FlorianRappl