Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed systemjs register function _export not return #571

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

wizard-a
Copy link
Contributor

@wizard-a wizard-a commented Dec 22, 2022

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

vite to compile pilet, systemjs register function _export not return

fix: #570

Remarks

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

File size impact

Merging develop into develop impact files as follow:

empty-piral (+0%)
Files new size
src/samples/empty-piral/dist/release/index.c426f7.js 32 kB 👶
src/samples/empty-piral/dist/release/index.10daed.js deleted (-32 kB)
src/samples/empty-piral/dist/release/index.html 315 B (0 B / +0%) 👻
Total (3) 32.3 kB (+1 B / +0%) ↗️
minimal-piral (+0%)
Files new size
src/samples/minimal-piral/dist/release/index.0677c1.js 250 kB 👶
src/samples/minimal-piral/dist/release/index.b3710e.js deleted (-250 kB)
src/samples/minimal-piral/dist/release/index.html 315 B (0 B / +0%) 👻
Total (3) 250 kB (+1 B / +0%) ↗️
sample-cross-fx (+0%)
Files new size
src/samples/sample-cross-fx/dist/release/index.91f9a3.js 2.11 MB 👶
src/samples/sample-cross-fx/dist/release/main.7eae60.css 1.67 kB 👶
src/samples/sample-cross-fx/dist/release/main.704ef7.css deleted (-1.67 kB)
src/samples/sample-cross-fx/dist/release/index.75863a.js deleted (-2.11 MB)
src/samples/sample-cross-fx/dist/release/index.html 454 B (0 B / +0%) 👻
Total (5) 2.12 MB (+3 B / +0%) ↗️
sample-piral (+0%)
Files new size
src/samples/sample-piral/dist/release/index.376ed5.js 467 kB 👶
src/samples/sample-piral/dist/release/main.aabdf0.css 170 kB 👶
src/samples/sample-piral/dist/release/main.4d50ba.css deleted (-170 kB)
src/samples/sample-piral/dist/release/index.dad4e7.js deleted (-467 kB)
src/samples/sample-piral/dist/release/index.html 490 B (0 B / +0%) 👻
Total (5) 638 kB (+1 B / +0%) ↗️
sample-piral-core (+0%)
Files new size
src/samples/sample-piral-core/dist/release/index.409ba6.js 300 kB 👶
src/samples/sample-piral-core/dist/release/main.3b5baf.css 3.6 kB 👶
src/samples/sample-piral-core/dist/release/main.53a04e.css deleted (-3.6 kB)
src/samples/sample-piral-core/dist/release/index.948673.js deleted (-300 kB)
src/samples/sample-piral-core/dist/release/index.html 436 B (0 B / +0%) 👻
Total (5) 304 kB (+1 B / +0%) ↗️
Generated by @jsenv/file-size-impact during check-bundle-size#3759132337 on 18470b2

@FlorianRappl FlorianRappl added this to the 0.15.5 milestone Dec 22, 2022
@FlorianRappl FlorianRappl added the bug Something isn't working label Dec 22, 2022
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@FlorianRappl FlorianRappl merged commit dd7c70e into smapiot:develop Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After pilet is packaged, export is added to the content of the module
3 participants