Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update Piral Inspector and Piral VS Code #573

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Docs: Update Piral Inspector and Piral VS Code #573

merged 5 commits into from
Jan 20, 2023

Conversation

manuelroemer
Copy link
Member

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

This includes some updates/refreshments to the Piral Inspector and Piral VS Code documentation. This addresses #541 and #540.

@manuelroemer manuelroemer added the documentation Concerns the available documentation. label Jan 20, 2023
This was linked to issues Jan 20, 2023
Improve Piral VSCode Extension Documentation #540
Closed
Update Piral Inspector Documentation #541
Closed
@manuelroemer
Be consistent with "," after i.e. and e.g..
3832b13 
Added footnote describing the purpose of Open VSX.
@FlorianRappl FlorianRappl added this to the 0.15.5 milestone Jan 20, 2023
@FlorianRappl FlorianRappl self-requested a review January 20, 2023 16:16
FlorianRappl
FlorianRappl reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!

Thanks for the outstanding work 🚀

docs/tools/piral-inspector.md Outdated Show resolved Hide resolved
docs/tools/piral-inspector.md Outdated Show resolved Hide resolved
docs/tools/vscode-piral.md Outdated Show resolved Hide resolved
@FlorianRappl FlorianRappl merged commit 24766e8 into documentation Jan 20, 2023
@FlorianRappl FlorianRappl deleted the docs/piral-inspector-and-vscode branch January 20, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianRappl FlorianRappl FlorianRappl approved these changes

Assignees
No one assigned
Labels
documentation Concerns the available documentation.
Projects
None yet
Milestone
0.15.5
Development

Successfully merging this pull request may close these issues.

Update Piral Inspector Documentation Improve Piral VSCode Extension Documentation
2 participants
@manuelroemer @FlorianRappl