Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 04-the-pilet-api.md #596

Closed

Conversation

thegreedychoice
Copy link

@thegreedychoice thegreedychoice commented Apr 27, 2023

The object params are missing for items unlike the id, and so the code won't compile

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

[Place a meaningful description here]

Remarks

[Optionally place any follow-up comments, remarks, observations, or notes here for future reference]

The object params are missing for items unlike the id, and so the code won't compile
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@FlorianRappl FlorianRappl added the documentation Concerns the available documentation. label Apr 28, 2023
@FlorianRappl
Copy link
Contributor

Can you please sign the CLA @thegreedychoice ? Thanks!

@FlorianRappl
Copy link
Contributor

Ping @thegreedychoice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Concerns the available documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants