Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Sign In OAuth2 Security Flaw #275

Closed
rish07 opened this issue Sep 28, 2020 · 10 comments · Fixed by #286
Closed

Google Sign In OAuth2 Security Flaw #275

rish07 opened this issue Sep 28, 2020 · 10 comments · Fixed by #286
Assignees
Labels
bug Something isn't working Hacktoberfest

Comments

@rish07
Copy link
Contributor

rish07 commented Sep 28, 2020

Hey @himanshusharma89
I was going through the app and came across the following issue:

  1. I pressed sign in with google on the sign-up page.
  2. Didn't select an account and pressed back.
  3. The app redirected me to the Dashboard with null values with though I wasn't authenticated.

I am attaching a screenshot of the app being logged in without auth.
WhatsApp Image 2020-09-29 at 1 50 59 AM

I would like to work on this issue as well along with the Github auth implementation during Hacktoberfest.

@github-actions
Copy link

We shall look into this issue. Thanks for bringing it to our notice!

@himanshusharma89
Copy link
Collaborator

Go ahead @rish07. Assigning this issue to you.

@himanshusharma89
Copy link
Collaborator

Any update @rish07?

@rish07
Copy link
Contributor Author

rish07 commented Oct 3, 2020

Hey @himanshusharma89,
I actually have an exam tomorrow so I'll fix it by tomorrow evening.

@himanshusharma89
Copy link
Collaborator

Okay, @rish07. Good luck.

@himanshusharma89
Copy link
Collaborator

Also, the null value is still there after successful sign-up, but it doesn't occur if we restart the app. I checked the mapping methods, it is fine but still, the issue is there. Have a look into this also.

@rish07
Copy link
Contributor Author

rish07 commented Oct 3, 2020

Sure

@arbazdiwan
Copy link

@himanshusharma89, I would like to solve this issue if @rish07 is facing any problems.

@himanshusharma89
Copy link
Collaborator

@arbazdiwan, @rish07 will work on it and update us soon

@arbazdiwan
Copy link

arbazdiwan commented Oct 3, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants