Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static folder not included in the PyPI package #19

Closed
mchaaler opened this issue Jan 26, 2022 · 4 comments · Fixed by #21
Closed

static folder not included in the PyPI package #19

mchaaler opened this issue Jan 26, 2022 · 4 comments · Fixed by #21

Comments

@mchaaler
Copy link
Contributor

Something to do with the 'include_package_data' option in setup.cfg?
Would adopting a src layout be a solution?

@smarie
Copy link
Owner

smarie commented Jan 27, 2022

Ouch, thanks for reporting this @mchaaler ! Yes, I will adopt such a layout to prevent mistakes. Indeed when the package folder appears at the root, it is automatically added by pytest in the python path, which makes the build pass even when there is a packaging mistake :(

smarie pushed a commit that referenced this issue Jan 27, 2022
…ed src/ structure. Added non-regression test. Fixed #19
@smarie
Copy link
Owner

smarie commented Jan 27, 2022

Fixed in 0.7.1 (with non-regression tests). Let me know if this works on your side ! (it should be available in a few minutes on pypi)

@mchaaler
Copy link
Contributor Author

Tested and approved (on a real-life project)! Thanks a lot!

@smarie
Copy link
Owner

smarie commented Jan 28, 2022

great ! thanks for letting me know. I had planned to use it on https://python-qds.github.io/qdscreen/ but did not yet have the bandwidth, so you are officially the first (non-self) user project !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants