-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nox test python 3.10 and 3.11 #52
Conversation
Ah I see, the github actions workflow needs to be approved by a maintainer before it will run, but when it does the results will be shown here. |
Thanks @GenevieveBuckley for this PR ! Indeed it seems that for first-time contributors the workflow needs approval. I just unlocked it. Thanks for the kind words ! I like very much This is why I ported and refactored a bit the code from An obvious (but demanding in reverse-engineering skills) contribution would therefore be to try to port a few of the tests from sphinx-gallery (issue #12) Another track (longer-term) that I see is extracting the core from this project into an independent lib so that both libs can use it. I have described this work in sphinx-gallery/sphinx-gallery#933 But for now the PR has some issues, probably related with a new version of mkdocs ? If you wish to investigate please open a dedicated issue first to declare it officially, before fixing it. Once again thanks @GenevieveBuckley for you enthusiasm ! |
So, to summarize:
|
THanks @GenevieveBuckley EDIT: |
You can now pull from main branch, this should be fine. Note that if the build is ok for these python versions, they should be added to the project description in Here : https://github.com/smarie/mkdocs-gallery/blob/main/setup.cfg#L28 |
Merged main branch, and added python 3.10 & 3.11 to the setup.cfg classifiers. Thanks! |
All set, thanks @GenevieveBuckley ! |
This is a nice library! I was trying to figure out how to extend it, and found that the nox test matrix does not include python 3.10 & 3.11.
This PR includes python 3.10 and 3.11 in the nox test matrix.
(It might also be a good idea to upgrade the python version used for the "release" "publish" "docs" & "flake8" jobs, since python 3.7 will be at end of life in June. But I haven't changed anything here yet - I want to see if the github actions workflow passes first)