Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-raise errors for better ExtensionError messages #58

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

GenevieveBuckley
Copy link
Contributor

This PR takes the string error message that was originally the problem, and includes that information into the ExtensionError message that the user will see.

Conext: I was getting an ExtensionError from the load_base_conf function (in gen_gallery.py). Turns out the fix was very simple (just install some extra dependencies), but it was difficult to figure that out since the ExtensionError does not provide much information.

@smarie
Copy link
Owner

smarie commented Nov 20, 2023

Thanks @GenevieveBuckley ! Sorry for taking so long to get back on this project.
Could you please simply update to the latest main branch and add a changelog entry ? I will ship a release in the upcoming days with all the recent changes that we can get merged in.

@GenevieveBuckley
Copy link
Contributor Author

Thanks @GenevieveBuckley ! Sorry for taking so long to get back on this project.

Not a problem!

Could you please simply update to the latest main branch and add a changelog entry ? I will ship a release in the upcoming days with all the recent changes that we can get merged in.

Sure thing, done.

@smarie smarie merged commit 35e7961 into smarie:main Nov 21, 2023
13 checks passed
@smarie
Copy link
Owner

smarie commented Nov 21, 2023

Thanks @GenevieveBuckley !

@GenevieveBuckley GenevieveBuckley deleted the reraise-error-messages branch November 21, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants